Add simple caching implementation for database queries that will be used in command autocompletion

tests/test_database/test_crud/conftest.py

@@ -1,34 +0,0 @@
-import datetime
-
-import pytest
-from sqlalchemy.ext.asyncio import AsyncSession
-
-from database.models import UforaAnnouncement, UforaCourse, UforaCourseAlias
-
-
-@pytest.fixture
-async def course(database_session: AsyncSession) -> UforaCourse:
-    """Fixture to create a course"""
-    course = UforaCourse(name="test", code="code", year=1, log_announcements=True)
-    database_session.add(course)
-    await database_session.commit()
-    return course
-
-
-@pytest.fixture
-async def course_with_alias(database_session: AsyncSession, course: UforaCourse) -> UforaCourse:
-    """Fixture to create a course with an alias"""
-    alias = UforaCourseAlias(course_id=course.course_id, alias="alias")
-    database_session.add(alias)
-    await database_session.commit()
-    await database_session.refresh(course)
-    return course
-
-
-@pytest.fixture
-async def announcement(course: UforaCourse, database_session: AsyncSession) -> UforaAnnouncement:
-    """Fixture to create an announcement"""
-    announcement = UforaAnnouncement(course_id=course.course_id, publication_date=datetime.datetime.now())
-    database_session.add(announcement)
-    await database_session.commit()
-    return announcement

tests/test_database/test_crud/test_ufora_announcements.py

@@ -25,19 +25,21 @@ async def test_get_courses_with_announcements(database_session: AsyncSession):
     assert results[0] == course_1
 
 
-async def test_create_new_announcement(course: UforaCourse, database_session: AsyncSession):
+async def test_create_new_announcement(ufora_course: UforaCourse, database_session: AsyncSession):
     """Test creating a new announcement"""
-    await crud.create_new_announcement(database_session, 1, course=course, publication_date=datetime.datetime.now())
-    await database_session.refresh(course)
-    assert len(course.announcements) == 1
+    await crud.create_new_announcement(
+        database_session, 1, course=ufora_course, publication_date=datetime.datetime.now()
+    )
+    await database_session.refresh(ufora_course)
+    assert len(ufora_course.announcements) == 1
 
 
-async def test_remove_old_announcements(announcement: UforaAnnouncement, database_session: AsyncSession):
+async def test_remove_old_announcements(ufora_announcement: UforaAnnouncement, database_session: AsyncSession):
     """Test removing all stale announcements"""
-    course = announcement.course
-    announcement.publication_date -= datetime.timedelta(weeks=2)
-    announcement_2 = UforaAnnouncement(course_id=announcement.course_id, publication_date=datetime.datetime.now())
-    database_session.add_all([announcement, announcement_2])
+    course = ufora_announcement.course
+    ufora_announcement.publication_date -= datetime.timedelta(weeks=2)
+    announcement_2 = UforaAnnouncement(course_id=ufora_announcement.course_id, publication_date=datetime.datetime.now())
+    database_session.add_all([ufora_announcement, announcement_2])
     await database_session.commit()
     await database_session.refresh(course)
     assert len(course.announcements) == 2

tests/test_database/test_crud/test_ufora_courses.py

@@ -4,19 +4,19 @@ from database.crud import ufora_courses as crud
 from database.models import UforaCourse
 
 
-async def test_get_course_by_name_exact(database_session: AsyncSession, course: UforaCourse):
+async def test_get_course_by_name_exact(database_session: AsyncSession, ufora_course: UforaCourse):
     """Test getting a course by its name when the query is an exact match"""
     match = await crud.get_course_by_name(database_session, "Test")
-    assert match == course
+    assert match == ufora_course
 
 
-async def test_get_course_by_name_substring(database_session: AsyncSession, course: UforaCourse):
+async def test_get_course_by_name_substring(database_session: AsyncSession, ufora_course: UforaCourse):
     """Test getting a course by its name when the query is a substring"""
     match = await crud.get_course_by_name(database_session, "es")
-    assert match == course
+    assert match == ufora_course
 
 
-async def test_get_course_by_name_alias(database_session: AsyncSession, course_with_alias: UforaCourse):
+async def test_get_course_by_name_alias(database_session: AsyncSession, ufora_course_with_alias: UforaCourse):
     """Test getting a course by its name when the name doesn't match, but the alias does"""
     match = await crud.get_course_by_name(database_session, "ali")
-    assert match == course_with_alias
+    assert match == ufora_course_with_alias

tests/test_database/test_utils/test_caches.py

@@ -0,0 +1,27 @@
+from sqlalchemy.ext.asyncio import AsyncSession
+
+from database.models import UforaCourse
+from database.utils.caches import UforaCourseCache
+
+
+async def test_ufora_course_cache_refresh_empty(database_session: AsyncSession, ufora_course_with_alias: UforaCourse):
+    """Test loading the data for the Ufora Course cache when it's empty"""
+    cache = UforaCourseCache()
+    await cache.refresh(database_session)
+
+    assert len(cache.data) == 2
+    assert cache.data == ["alias", "test"]
+
+
+async def test_ufora_course_cache_refresh_not_empty(
+    database_session: AsyncSession, ufora_course_with_alias: UforaCourse
+):
+    """Test loading the data for the Ufora Course cache when it's not empty anymore"""
+    cache = UforaCourseCache()
+    cache.data = ["Something"]
+    cache.data_transformed = ["something"]
+
+    await cache.refresh(database_session)
+
+    assert len(cache.data) == 2
+    assert cache.data == ["alias", "test"]