From 6532fbebb116a1630a36f2b0a2e82e1d2a541981 Mon Sep 17 00:00:00 2001
From: Jef Roosens <roosensjef@gmail.com>
Date: Sat, 1 May 2021 21:11:13 +0200
Subject: [PATCH 1/2] Fixed frontend linter

---
 web/package.json     | 4 ++--
 web/src/api/ivago.ts | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/web/package.json b/web/package.json
index e19388b..0534f03 100644
--- a/web/package.json
+++ b/web/package.json
@@ -5,8 +5,8 @@
     "dev": "vite",
     "build": "vue-tsc --noEmit && vite build",
     "serve": "vite preview",
-    "lint": "eslint \"src/**\"",
-    "format": "eslint --fix \"src/**\""
+    "lint": "eslint --ext .js,.vue src",
+    "format": "yarn run lint --fix"
   },
   "dependencies": {
     "vue": "^3.0.5",
diff --git a/web/src/api/ivago.ts b/web/src/api/ivago.ts
index 4c01856..7fa15a4 100644
--- a/web/src/api/ivago.ts
+++ b/web/src/api/ivago.ts
@@ -3,11 +3,11 @@ export interface Street {
     city: string
 }
 
-export async function search (search_term: string): Promise<Street[]> {
-    const base_url = import.meta.env.VITE_ENDPOINT as string
+export async function search (searchTerm: string): Promise<Street[]> {
+    const baseURL = import.meta.env.VITE_ENDPOINT as string
 
-    const r = await fetch(`${base_url}/ivago/search?` + new URLSearchParams({
-        q: search_term
+    const r = await fetch(`${baseURL}/ivago/search?` + new URLSearchParams({
+        q: searchTerm
     }))
 
     if (!r.ok) {

From 1da94c5211daa394dbaa7ca9e1edb2c20b1ea08e Mon Sep 17 00:00:00 2001
From: Jef Roosens <roosensjef@gmail.com>
Date: Sat, 1 May 2021 21:22:12 +0200
Subject: [PATCH 2/2] Fixed eslint errors

---
 web/src/App.vue                   |  6 ++--
 web/src/components/HelloWorld.vue | 51 -------------------------------
 web/src/components/Home.vue       |  8 +++--
 web/src/components/Ivago.vue      | 28 +++++++++++------
 4 files changed, 28 insertions(+), 65 deletions(-)
 delete mode 100644 web/src/components/HelloWorld.vue

diff --git a/web/src/App.vue b/web/src/App.vue
index f19b1c3..f629716 100644
--- a/web/src/App.vue
+++ b/web/src/App.vue
@@ -1,6 +1,8 @@
 <template>
-    <Nav />
-    <router-view />
+    <div>
+        <Nav />
+        <router-view />
+    </div>
 </template>
 
 <script lang="ts">
diff --git a/web/src/components/HelloWorld.vue b/web/src/components/HelloWorld.vue
deleted file mode 100644
index 1ddbac8..0000000
--- a/web/src/components/HelloWorld.vue
+++ /dev/null
@@ -1,51 +0,0 @@
-<template>
-    <h1>Fej Frontend</h1>
-
-    <input id="street" type="text" placeholder="street" v-model="street" />
-    <button :onClick="onSubmit">Search</button>
-
-    <ul>
-        <li v-for="res in results">{{res.name}} ({{res.city}})</li>
-    </ul>
-</template>
-
-<script lang="ts">
-import { defineComponent } from 'vue'
-import { Street, Ivago } from '../api/ivago'
-
-export default defineComponent({
-    name: 'HelloWorld',
-    data () {
-        return {
-            street: '',
-            results: [] as Street[]
-        }
-    },
-    methods: {
-        onSubmit () {
-            new Ivago(import.meta.env.VITE_ENDPOINT as string).search(this.$data.street)
-                .then(res => {
-                    this.$data.results = res
-                })
-        }
-    }
-})
-</script>
-
-<style scoped>
-a {
-  color: #42b983;
-}
-
-label {
-  margin: 0 0.5em;
-  font-weight: bold;
-}
-
-code {
-  background-color: #eee;
-  padding: 2px 4px;
-  border-radius: 4px;
-  color: #304455;
-}
-</style>
diff --git a/web/src/components/Home.vue b/web/src/components/Home.vue
index cdb41ed..181d6e9 100644
--- a/web/src/components/Home.vue
+++ b/web/src/components/Home.vue
@@ -1,7 +1,9 @@
 <template>
-    <h1>Fej</h1>
-    <p>Welcome to Fej, my frontend/backend combo.</p>
-    <p>If you can see this, the cicd worked!</p>
+    <div>
+        <h1>Fej</h1>
+        <p>Welcome to Fej, my frontend/backend combo.</p>
+        <p>If you can see this, the cicd worked!</p>
+    </div>
 </template>
 
 <script lang="ts">
diff --git a/web/src/components/Ivago.vue b/web/src/components/Ivago.vue
index be2779b..bd0766d 100644
--- a/web/src/components/Ivago.vue
+++ b/web/src/components/Ivago.vue
@@ -1,17 +1,27 @@
 <template>
-    <h1>Ivago</h1>
-    <input v-model="query" v-on:keyup.enter="search" type="text" placeholder="Street..." />
-    <div id="scroll-list">
-        <ul v-if="msg === ''">
-            <li v-for="item in items">{{ item.name }} ({{ item.city }})</li>
-        </ul>
-        <p v-else>{{ msg }}</p>
+    <div>
+        <h1>Ivago</h1>
+        <input
+            v-model="query"
+            v-on:keyup.enter="search"
+            type="text"
+            placeholder="Street..." />
+        <div id="scroll-list">
+            <ul v-if="msg === ''">
+                <li
+                    v-for="item in items"
+                    v-bind:key="`${item.name} (${item.city})`" >
+                    {{ item.name }} ({{ item.city }})
+                </li>
+            </ul>
+            <p v-else>{{ msg }}</p>
+        </div>
     </div>
 </template>
 
 <script lang="ts">
 import { defineComponent } from 'vue'
-import { Street, search as ivago_search } from '../api/ivago'
+import { Street, search as ivagoSearch } from '../api/ivago'
 
 export default defineComponent({
     name: 'Ivago',
@@ -32,7 +42,7 @@ export default defineComponent({
                 return
             }
 
-            ivago_search(this.query)
+            ivagoSearch(this.query)
                 .then((res: Street[]) => {
                     this.items = res
                     this.msg = ''