chore: integrate cppcheck into workflow

This commit is contained in:
Jef Roosens 2023-11-14 10:49:12 +01:00
parent b053aa6c93
commit 6af3e6ad6d
Signed by: Jef Roosens
GPG key ID: B75D4F293C7052DB
17 changed files with 64 additions and 69 deletions

View file

@ -32,6 +32,8 @@ lsm_error lsm_trie_init(lsm_trie **ptr) {
lsm_error res = lsm_trie_node_init(&root);
if (res != lsm_error_ok) {
free(trie);
return res;
}
@ -41,7 +43,7 @@ lsm_error lsm_trie_init(lsm_trie **ptr) {
return lsm_error_ok;
}
uint64_t lsm_trie_size(lsm_trie *trie) { return trie->size; }
uint64_t lsm_trie_size(const lsm_trie *trie) { return trie->size; }
lsm_error lsm_trie_insert(lsm_trie *trie, lsm_str *key, void *data) {
// NULL is not allowed as a data value, as it's used to indicate a lack of
@ -67,11 +69,10 @@ lsm_error lsm_trie_insert(lsm_trie *trie, lsm_str *key, void *data) {
uint64_t index = 0;
lsm_trie_node *node = trie->root;
lsm_trie_node *next_node;
lsm_error res;
while (index < key_len) {
char c = lsm_str_char(key, index);
res = lsm_bt_search((void **)&next_node, &node->bt, c);
lsm_error res = lsm_bt_search((void **)&next_node, &node->bt, c);
// No child is present yet for this character, so we can insert the string
// here
@ -165,11 +166,10 @@ lsm_error lsm_trie_search(void **out, lsm_trie *trie, lsm_str *key) {
uint64_t index = 0;
lsm_trie_node *node = trie->root;
lsm_trie_node *next_node;
lsm_error res;
while (index < key_len) {
char c = lsm_str_char(key, index);
res = lsm_bt_search((void **)&next_node, &node->bt, c);
lsm_error res = lsm_bt_search((void **)&next_node, &node->bt, c);
if (res != lsm_error_ok) {
return res;
@ -220,12 +220,10 @@ lsm_error lsm_trie_remove(void **data, lsm_trie *trie, lsm_str *key) {
uint64_t index = 0;
lsm_trie_node *parent = trie->root;
lsm_trie_node *child;
lsm_error res;
char c;
while (index < key_len) {
c = lsm_str_char(key, index);
res = lsm_bt_search((void **)&child, &parent->bt, c);
char c = lsm_str_char(key, index);
lsm_error res = lsm_bt_search((void **)&child, &parent->bt, c);
if (res != lsm_error_ok) {
return res;