Chewing_Bever
/
st
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Fix techo handling of control and multibyte characters. 

techo compares signed char to '\x20'. Any character with code less then
'\x20' is treated as control character.  This way characters with MSB
set to 1 are considered control characters too.

Also this patch makes techo display DEL character as ^?.

To reprocuce the bug, enable echo mode using printf '\e[12l',
then type DEL character or any non-ASCII character.
dev
noname 2014-04-23 00:26:07 +04:00 committed by Roberto E. Vargas Caballero
parent fa19f241a3
commit f9dc374ea0
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
st.c
View File

@ -2308,9 +2308,9 @@ techo(char *buf, int len) {
for(; len > 0; buf++, len--) { for(; len > 0; buf++, len--) {
char c = *buf; char c = *buf;
if(c < '\x20') { /* control code */ if(c < 0x20 || c == 0177) { /* control code */
if(c != '\n' && c != '\r' && c != '\t') { if(c != '\n' && c != '\r' && c != '\t') {
c |= '\x40'; c ^= '\x40';
tputc("^", 1); tputc("^", 1);
} }
tputc(&c, 1); tputc(&c, 1);