rusty-bever
/
gateway-old
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Added some comments

proxy
Jef Roosens 2021-11-26 23:11:03 +01:00
parent bda49d53c4
commit f3c9326c0c
Signed by: Jef Roosens
GPG Key ID: 955C0660072F691F
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/proxy.rs
View File

@ -1,3 +1,4 @@
//! This file is heavily inspired by the FileServer implementation in Rocket
use std::path::{Path, PathBuf}; use std::path::{Path, PathBuf};
use futures::stream::TryStreamExt; use futures::stream::TryStreamExt;
@ -87,7 +88,9 @@ impl Handler for ProxyServer
use rocket::http::uri::fmt::Path; use rocket::http::uri::fmt::Path;
// ROCKET REQUEST -> REQWEST REQUEST // ROCKET REQUEST -> REQWEST REQUEST
// Path
// We first parse the path & prepend it with the prefix. If we can't parse it, we return a
// BadRequest.
let allow_dotfiles = self.options.contains(Options::DotFiles); let allow_dotfiles = self.options.contains(Options::DotFiles);
let path = req.segments::<Segments<'_, Path>>(0..).ok() let path = req.segments::<Segments<'_, Path>>(0..).ok()
.and_then(|segments| segments.to_path_buf(allow_dotfiles).ok()) .and_then(|segments| segments.to_path_buf(allow_dotfiles).ok())
@ -97,13 +100,14 @@ impl Handler for ProxyServer
return Outcome::Failure(Status::BadRequest); return Outcome::Failure(Status::BadRequest);
} }
let path = path.unwrap(); let path = path.unwrap(); // Unwrap is safe because we check for is_none() beforehand
let path_str = path.to_str(); // Unwrap is safe because we check for is_none() beforehand let path_str = path.to_str();
if path_str.is_none() { if path_str.is_none() {
return Outcome::Failure(Status::BadRequest); return Outcome::Failure(Status::BadRequest);
} }
// After confirming we can parse the path, we check if it needs to be normalized
if self.options.contains(Options::NormalizeDirs) && !req.uri().path().ends_with('/') { if self.options.contains(Options::NormalizeDirs) && !req.uri().path().ends_with('/') {
let normal = req.uri().map_path(|p| format!("{}/", p)) let normal = req.uri().map_path(|p| format!("{}/", p))
.expect("adding a trailing slash to a known good path => valid path") .expect("adding a trailing slash to a known good path => valid path")
@ -112,6 +116,7 @@ impl Handler for ProxyServer
return Outcome::from_or_forward(req, data, Redirect::permanent(normal)); return Outcome::from_or_forward(req, data, Redirect::permanent(normal));
} }
// Finally, we create our new URL by combining the root, path & query
let path_str = path_str.unwrap(); let path_str = path_str.unwrap();
let query_part = req let query_part = req
@ -126,7 +131,7 @@ impl Handler for ProxyServer
query_part query_part
); );
// Headers // Here, we convert the Rocket headers into a HeaderMap that reqwest can use.
let mut headers = HeaderMap::new(); let mut headers = HeaderMap::new();
for header in req.headers().iter() { for header in req.headers().iter() {
@ -142,14 +147,14 @@ impl Handler for ProxyServer
headers.insert(name, value); headers.insert(name, value);
} }
// Method // Each method needs to be matched against the other's version
let method = match req.method() { let method = match req.method() {
Method::Delete => ReqMethod::DELETE, Method::Delete => ReqMethod::DELETE,
Method::Get => ReqMethod::GET, Method::Get => ReqMethod::GET,
Method::Patch => ReqMethod::PATCH, Method::Patch => ReqMethod::PATCH,
Method::Post => ReqMethod::POST, Method::Post => ReqMethod::POST,
Method::Put => ReqMethod::PUT, Method::Put => ReqMethod::PUT,
_ => todo!(), _ => todo!(), // This should never be reached as the proxy only mounts on these five routes
}; };
// And finally, the data // And finally, the data