From d11d0749608136d3a9c4e64e3411487a161d28cb Mon Sep 17 00:00:00 2001 From: Jef Roosens Date: Sun, 22 Jan 2023 12:35:55 +0100 Subject: [PATCH] chore: some reorganising --- README.md | 3 +++ include/vieter_cron.h | 1 - include/vieter_heap.h | 1 - src/cron/vieter_cron_parse.c | 4 ++++ 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 9381fb1..0c33ab0 100644 --- a/README.md +++ b/README.md @@ -36,6 +36,9 @@ All file names, function names... (even internals) should follow snake case convention and have a prefix unique to that module, starting with `vieter_`. For example, the `cron` modules uses the `vieter_cron_` prefix for everything. +Header files should only import what they explicitely need. If some function is +only used in a .c file, the import should be placed in the .c file instead. + ### Testing This library uses [Acutest](https://github.com/mity/acutest) for its tests. diff --git a/include/vieter_cron.h b/include/vieter_cron.h index 8c50fff..81a2630 100644 --- a/include/vieter_cron.h +++ b/include/vieter_cron.h @@ -1,7 +1,6 @@ #ifndef VIETER_CRON #define VIETER_CRON -#include #include #include #include diff --git a/include/vieter_heap.h b/include/vieter_heap.h index 4c8d1e5..5d08ebc 100644 --- a/include/vieter_heap.h +++ b/include/vieter_heap.h @@ -1,7 +1,6 @@ #ifndef VIETER_HEAP #define VIETER_HEAP -#include #include typedef struct vieter_heap vieter_heap; diff --git a/src/cron/vieter_cron_parse.c b/src/cron/vieter_cron_parse.c index 5c8da06..a82d1c3 100644 --- a/src/cron/vieter_cron_parse.c +++ b/src/cron/vieter_cron_parse.c @@ -1,4 +1,8 @@ #include "vieter_cron.h" +#include +#include +#include +#include // This prefix is needed to properly compile const uint8_t parse_month_days[] = {31, 28, 31, 30, 31, 30,