PR template: ask for fn docs and tests
							parent
							
								
									4b3b69ab15
								
							
						
					
					
						commit
						0bb3acef87
					
				| 
						 | 
					@ -3,6 +3,19 @@ Don't use past tense (e.g. "fixed foo bar").
 | 
				
			||||||
 | 
					
 | 
				
			||||||
Explain what your PR does and why.
 | 
					Explain what your PR does and why.
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					If you are adding a new function, please document it and add tests:
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					```
 | 
				
			||||||
 | 
					// foo does foo and bar
 | 
				
			||||||
 | 
					fn foo() {
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					// file_test.v
 | 
				
			||||||
 | 
					fn test_foo() {
 | 
				
			||||||
 | 
					    assert foo() == ...
 | 
				
			||||||
 | 
					    ...
 | 
				
			||||||
 | 
					}
 | 
				
			||||||
 | 
					```
 | 
				
			||||||
 | 
					
 | 
				
			||||||
Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice:
 | 
					Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice:
 | 
				
			||||||
 | 
					
 | 
				
			||||||
./v -o v
 | 
					./v -o v
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in New Issue