vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

url: fix parse (#14456)

master
David 'Epper' Marshall 2022-05-19 19:58:58 -04:00 committed by GitHub
parent 95d24e543d
commit 23568f19da
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
vlib/net/urllib/urllib.v
View File

@ -599,7 +599,7 @@ fn parse_host(host string) ?string {
return host1 + host2 + host3 return host1 + host2 + host3
} }
if idx := host.last_index(':') { if idx := host.last_index(':') {
colon_port = host[idx..] colon_port = host[idx..i]
if !valid_optional_port(colon_port) { if !valid_optional_port(colon_port) {
return error(error_msg('parse_host: invalid port $colon_port after host ', return error(error_msg('parse_host: invalid port $colon_port after host ',
'')) ''))

21
vlib/net/urllib/urllib_test.v
View File

@ -98,3 +98,24 @@ fn test_parse_empty_query_two() ? {
assert qvalues_map == {} assert qvalues_map == {}
assert query_str == query_encode assert query_str == query_encode
} }
fn test_parse() ? {
urls := [
'jdbc:mysql://test_user:ouupppssss@localhost:3306/sakila?profileSQL=true',
'ftp://ftp.is.co.za/rfc/rfc1808.txt',
'http://www.ietf.org/rfc/rfc2396.txt#header1',
'ldap://[2001:db8::7]/c=GB?objectClass=one&objectClass=two',
'mailto:John.Doe@example.com',
'news:comp.infosystems.www.servers.unix',
'tel:+1-816-555-1212',
'telnet://192.0.2.16:80/',
'urn:oasis:names:specification:docbook:dtd:xml:4.1.2',
'foo://example.com:8042/over/there?name=ferret#nose',
]
for url in urls {
_ := urllib.parse(url) or {
assert false
panic('FAILED parsing url')
}
}
}