vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

ci: sanitize compiler for tests (#7685)

pull/7695/head
ka-weihe 2020-12-29 19:27:57 +01:00 committed by GitHub
parent e8cd056eb6
commit 2c65c5c61a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 25 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
.github/workflows/ci.yml vendored
View File

@ -377,7 +377,7 @@ jobs:
echo "Running it..." echo "Running it..."
ls ls
ubuntu-clang-sanitize-undefined: tests-sanitize-undefined:
runs-on: ubuntu-latest runs-on: ubuntu-latest
timeout-minutes: 30 timeout-minutes: 30
env: env:
@ -398,9 +398,9 @@ jobs:
- name: Build V - name: Build V
run: make -j4 && ./v -cc clang -cg -cflags -Werror -o v cmd/v run: make -j4 && ./v -cc clang -cg -cflags -Werror -o v cmd/v
- name: Fixed tests (-fsanitize=undefined) - name: Fixed tests (-fsanitize=undefined)
run: ./v -cflags -fsanitize=undefined test-fixed run: ./v -cc clang -cflags "-fsanitize=undefined" -o v2 cmd/v && ./v2 -cflags -fsanitize=undefined test-fixed
ubuntu-clang-sanitize-address: tests-sanitize-address:
runs-on: ubuntu-latest runs-on: ubuntu-latest
timeout-minutes: 30 timeout-minutes: 30
env: env:
@ -423,7 +423,7 @@ jobs:
- name: Fixed tests (-fsanitize=address) - name: Fixed tests (-fsanitize=address)
run: ASAN_OPTIONS=detect_leaks=0 ./v -cflags -fsanitize=address test-fixed run: ASAN_OPTIONS=detect_leaks=0 ./v -cflags -fsanitize=address test-fixed
ubuntu-clang-sanitize-memory: tests-sanitize-memory:
runs-on: ubuntu-latest runs-on: ubuntu-latest
timeout-minutes: 30 timeout-minutes: 30
env: env:

11
cmd/tools/vtest-fixed.v
View File

@ -18,7 +18,7 @@ const (
'vlib/sqlite/sqlite_test.v', 'vlib/sqlite/sqlite_test.v',
'vlib/vweb/tests/vweb_test.v', 'vlib/vweb/tests/vweb_test.v',
'vlib/x/websocket/websocket_test.v', 'vlib/x/websocket/websocket_test.v',
'vlib/v/tests/unsafe_test.v' 'vlib/v/tests/unsafe_test.v',
] ]
skip_with_fsanitize_address = [ skip_with_fsanitize_address = [
'vlib/encoding/base64/base64_test.v', 'vlib/encoding/base64/base64_test.v',
@ -49,10 +49,10 @@ const (
'vlib/v/tests/vmod_parser_test.v', 'vlib/v/tests/vmod_parser_test.v',
'vlib/v/vcache/vcache_test.v', 'vlib/v/vcache/vcache_test.v',
'vlib/x/json2/decoder_test.v', 'vlib/x/json2/decoder_test.v',
'vlib/x/websocket/websocket_test.v' 'vlib/x/websocket/websocket_test.v',
] ]
skip_with_fsanitize_undefined = [ skip_with_fsanitize_undefined = [
'vlib/encoding/csv/reader_test.v' 'vlib/encoding/csv/reader_test.v',
] ]
skip_test_files = [ skip_test_files = [
'vlib/net/http/http_httpbin_test.v', 'vlib/net/http/http_httpbin_test.v',
@ -61,7 +61,7 @@ const (
'vlib/v/tests/profile/profile_test.v', 'vlib/v/tests/profile/profile_test.v',
] ]
skip_on_ubuntu_musl = [ skip_on_ubuntu_musl = [
// 'vlib/v/gen/js/jsgen_test.v', /* 'vlib/v/gen/js/jsgen_test.v', */
'vlib/net/http/cookie_test.v', 'vlib/net/http/cookie_test.v',
'vlib/net/http/http_test.v', 'vlib/net/http/http_test.v',
'vlib/net/http/status_test.v', 'vlib/net/http/status_test.v',
@ -113,7 +113,7 @@ fn main() {
sanitize_address = true sanitize_address = true
} }
if '-fsanitize=undefined' in arg { if '-fsanitize=undefined' in arg {
sanitize_address = true sanitize_undefined = true
} }
} }
if sanitize_memory { if sanitize_memory {
@ -125,6 +125,7 @@ fn main() {
if sanitize_undefined { if sanitize_undefined {
tsession.skip_files << skip_with_fsanitize_undefined tsession.skip_files << skip_with_fsanitize_undefined
} }
println(tsession.skip_files)
// //
if os.getenv('V_CI_MUSL').len > 0 { if os.getenv('V_CI_MUSL').len > 0 {
tsession.skip_files << skip_on_musl tsession.skip_files << skip_on_musl

6
vlib/v/checker/checker.v
View File

@ -2083,7 +2083,7 @@ pub fn (mut c Checker) const_decl(mut node ast.ConstDecl) {
pub fn (mut c Checker) enum_decl(decl ast.EnumDecl) { pub fn (mut c Checker) enum_decl(decl ast.EnumDecl) {
c.check_valid_pascal_case(decl.name, 'enum name', decl.pos) c.check_valid_pascal_case(decl.name, 'enum name', decl.pos)
mut seen := []int{} mut seen := []i64{}
for i, field in decl.fields { for i, field in decl.fields {
if !c.pref.experimental && util.contains_capital(field.name) { if !c.pref.experimental && util.contains_capital(field.name) {
// TODO C2V uses hundreds of enums with capitals, remove -experimental check once it's handled // TODO C2V uses hundreds of enums with capitals, remove -experimental check once it's handled
@ -2101,10 +2101,10 @@ pub fn (mut c Checker) enum_decl(decl ast.EnumDecl) {
val := field.expr.val.i64() val := field.expr.val.i64()
if val < int_min || val > int_max { if val < int_min || val > int_max {
c.error('enum value `$val` overflows int', field.expr.pos) c.error('enum value `$val` overflows int', field.expr.pos)
} else if !decl.is_multi_allowed && int(val) in seen { } else if !decl.is_multi_allowed && i64(val) in seen {
c.error('enum value `$val` already exists', field.expr.pos) c.error('enum value `$val` already exists', field.expr.pos)
} }
seen << int(val) seen << i64(val)
} }
ast.PrefixExpr {} ast.PrefixExpr {}
else { else {