vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

autofree: string.replace() test

pull/6666/head
Alexander Medvednikov 2020-10-21 19:44:31 +02:00
parent 019e3b2f4a
commit 6d11caf784
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
vlib/builtin/string.v
View File

@ -183,6 +183,11 @@ pub fn (s string) replace(rep string, with string) string {
// TODO PERF Allocating ints is expensive. Should be a stack array // TODO PERF Allocating ints is expensive. Should be a stack array
// Get locations of all reps within this string // Get locations of all reps within this string
mut idxs := []int{} mut idxs := []int{}
defer {
unsafe {
idxs.free()
}
}
mut idx := 0 mut idx := 0
for { for {
idx = s.index_after(rep, idx) idx = s.index_after(rep, idx)

8
vlib/v/tests/valgrind/1.strings_and_arrays.v
View File

@ -61,12 +61,16 @@ fn str_inter() {
} }
fn str_replace() { fn str_replace() {
s := 'hello world' mut s := 'hello world'
s = s.replace('hello', 'hi')
println(s)
/*
r := s.replace('hello', 'hi') r := s.replace('hello', 'hi')
cloned := s.replace('hello', 'hi').clone() cloned := s.replace('hello', 'hi').clone()
cloned2 := r.clone() cloned2 := r.clone()
println(s) println(s)
println(r) println(r)
*/
} }
fn reassign_str() { fn reassign_str() {
@ -154,7 +158,7 @@ fn main() {
reassign_str() reassign_str()
optional_str() optional_str()
optional_return() optional_return()
// str_replace() str_replace()
if_cond() if_cond()
addition_with_tmp_expr() addition_with_tmp_expr()
println('end') println('end')