vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

stats: use c style for loop

pull/2663/head
Daren Liang 2019-11-05 20:45:05 -05:00 committed by Alexander Medvednikov
parent af81b02ef0
commit 91bb969ed1
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vlib/math/stats/stats.v
View File

@ -118,13 +118,11 @@ pub fn mode(arr []f64) f64 {
for v in arr { for v in arr {
freqs<<freq(arr,v) freqs<<freq(arr,v)
} }
mut i := 0
mut max := 0 mut max := 0
for i < freqs.len { for i := 0; i < freqs.len; i++ {
if freqs[i] > freqs[max] { if freqs[i] > freqs[max] {
max = i max = i
} }
i++
} }
return arr[max] return arr[max]
} }

1
vlib/math/stats/stats_test.v
View File

@ -35,7 +35,6 @@ fn test_geometric_mean() {
assert o.str().eq('5.159932') assert o.str().eq('5.159932')
data = [f64(-3.0),f64(67.31),f64(4.4),f64(1.89)] data = [f64(-3.0),f64(67.31),f64(4.4),f64(1.89)]
o = stats.geometric_mean(data) o = stats.geometric_mean(data)
println(o)
// Some issue with precision comparison in f64 using == operator hence serializing to string // Some issue with precision comparison in f64 using == operator hence serializing to string
assert o.str().eq('nan') || o.str().eq('-nan') || o.str().eq('-1.#IND00') || o == f64(0) || o.str().eq('-nan(ind)') // Because in math it yields a complex number assert o.str().eq('nan') || o.str().eq('-nan') || o.str().eq('-1.#IND00') || o == f64(0) || o.str().eq('-nan(ind)') // Because in math it yields a complex number
data = [f64(12.0),f64(7.88),f64(76.122),f64(54.83)] data = [f64(12.0),f64(7.88),f64(76.122),f64(54.83)]