vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

checker: check sumtype common fields for mutability when assigning too

pull/11383/head
Delyan Angelov 2021-09-03 13:21:35 +03:00
parent a4df418a68
commit 96ef553f59
No known key found for this signature in database
GPG Key ID: 66886C0F12D595ED
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
vlib/v/checker/checker.v
View File

@ -1823,6 +1823,7 @@ fn (mut c Checker) fail_if_immutable(expr ast.Expr) (string, token.Position) {
c.error('$expr_name must be added to the `lock` list above', c.error('$expr_name must be added to the `lock` list above',
expr.pos) expr.pos)
} }
return '', expr.pos
} }
to_lock = expr_name to_lock = expr_name
pos = expr.pos pos = expr.pos
@ -1851,6 +1852,22 @@ fn (mut c Checker) fail_if_immutable(expr ast.Expr) (string, token.Position) {
type_str := c.table.type_to_str(expr.expr_type) type_str := c.table.type_to_str(expr.expr_type)
c.error('field `$expr.field_name` of interface `$type_str` is immutable', c.error('field `$expr.field_name` of interface `$type_str` is immutable',
expr.pos) expr.pos)
return '', expr.pos
}
c.fail_if_immutable(expr.expr)
}
.sum_type {
sumtype_info := typ_sym.info as ast.SumType
mut field_info := sumtype_info.find_field(expr.field_name) or {
type_str := c.table.type_to_str(expr.expr_type)
c.error('unknown field `${type_str}.$expr.field_name`', expr.pos)
return '', pos
}
if !field_info.is_mut {
type_str := c.table.type_to_str(expr.expr_type)
c.error('field `$expr.field_name` of sumtype `$type_str` is immutable',
expr.pos)
return '', expr.pos
} }
c.fail_if_immutable(expr.expr) c.fail_if_immutable(expr.expr)
} }
@ -1858,6 +1875,7 @@ fn (mut c Checker) fail_if_immutable(expr ast.Expr) (string, token.Position) {
// This should only happen in `builtin` // This should only happen in `builtin`
if c.file.mod.name != 'builtin' { if c.file.mod.name != 'builtin' {
c.error('`$typ_sym.kind` can not be modified', expr.pos) c.error('`$typ_sym.kind` can not be modified', expr.pos)
return '', expr.pos
} }
} }
.aggregate, .placeholder { .aggregate, .placeholder {
@ -1865,6 +1883,7 @@ fn (mut c Checker) fail_if_immutable(expr ast.Expr) (string, token.Position) {
} }
else { else {
c.error('unexpected symbol `$typ_sym.kind`', expr.pos) c.error('unexpected symbol `$typ_sym.kind`', expr.pos)
return '', expr.pos
} }
} }
} }
@ -1891,6 +1910,7 @@ fn (mut c Checker) fail_if_immutable(expr ast.Expr) (string, token.Position) {
else { else {
if !expr.is_lit() { if !expr.is_lit() {
c.error('unexpected expression `$expr.type_name()`', expr.position()) c.error('unexpected expression `$expr.type_name()`', expr.position())
return '', pos
} }
} }
} }