From cbf5de7c8ffa8ad6354d333ece0e33909811fd0f Mon Sep 17 00:00:00 2001 From: Alexander Medvednikov Date: Sun, 29 Sep 2019 04:28:57 +0300 Subject: [PATCH] PR template: add a test if you fixed a bug --- .github/PULL_REQUEST_TEMPLATE | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index 018eafa91c..e7651ca6cc 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -1,4 +1,4 @@ -Please, delete this in your PR, after reading it. +**Please delete this information after reading it.* Please title your PR as follows: `time: fix foo bar`. Always start with the thing you are fixing, then describe the fix. Don't use past tense (e.g. "fixed foo bar"). @@ -18,6 +18,8 @@ fn test_foo() { } ``` +If you are fixing a bug, please add a test that covers it. + Before submitting a PR, please run the tests with `make test`, and make sure V can still compile itself. Run this twice: ./v -o v compiler