vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

checker: only check ForInStmt.high once

pull/5647/head
joe-conigliaro 2020-07-04 19:10:37 +10:00
parent 95696559b7
commit cdd4a7c880
No known key found for this signature in database
GPG Key ID: C12F7136C08206F1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vlib/v/checker/checker.v
View File

@ -1833,7 +1833,8 @@ fn (mut c Checker) stmt(node ast.Stmt) {
typ := c.expr(node.cond) typ := c.expr(node.cond)
typ_idx := typ.idx() typ_idx := typ.idx()
if node.is_range { if node.is_range {
high_type_idx := c.expr(node.high).idx() high_type := c.expr(node.high)
high_type_idx := high_type.idx()
if typ_idx in table.integer_type_idxs && high_type_idx !in table.integer_type_idxs { if typ_idx in table.integer_type_idxs && high_type_idx !in table.integer_type_idxs {
c.error('range types do not match', node.cond.position()) c.error('range types do not match', node.cond.position())
} else if typ_idx in table.float_type_idxs || high_type_idx in table.float_type_idxs { } else if typ_idx in table.float_type_idxs || high_type_idx in table.float_type_idxs {
@ -1843,7 +1844,6 @@ fn (mut c Checker) stmt(node ast.Stmt) {
} else if typ_idx == table.string_type_idx || high_type_idx == table.string_type_idx { } else if typ_idx == table.string_type_idx || high_type_idx == table.string_type_idx {
c.error('range type can not be string', node.cond.position()) c.error('range type can not be string', node.cond.position())
} }
c.expr(node.high)
} else { } else {
mut scope := c.file.scope.innermost(node.pos.pos) mut scope := c.file.scope.innermost(node.pos.pos)
sym := c.table.get_type_symbol(typ) sym := c.table.get_type_symbol(typ)