os: improve `rm` error message (#8719)

pull/8678/head
Nick Treleaven 2021-02-13 12:51:38 +00:00 committed by GitHub
parent 0b60510c9c
commit d03c1d615a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 9 deletions

View File

@ -432,17 +432,14 @@ pub fn is_readable(path string) bool {
// rm removes file in `path`. // rm removes file in `path`.
pub fn rm(path string) ? { pub fn rm(path string) ? {
mut rc := 0
$if windows { $if windows {
rc := C._wremove(path.to_wide()) rc = C._wremove(path.to_wide())
if rc == -1 {
// TODO: proper error as soon as it's supported on windows
return error('Failed to remove "$path"')
}
} $else { } $else {
rc := C.remove(charptr(path.str)) rc = C.remove(charptr(path.str))
if rc == -1 {
return error(posix_get_error_msg(C.errno))
} }
if rc == -1 {
return error('Failed to remove "$path": ' + posix_get_error_msg(C.errno))
} }
// C.unlink(path.cstr()) // C.unlink(path.cstr())
} }