vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

checker: fix struct cast (#7308)

pull/7342/head
Swastik Baranwal 2020-12-15 09:00:51 +05:30 committed by GitHub
parent c922565525
commit da9588c1a5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 82 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
vlib/v/checker/checker.v
View File

@ -3182,6 +3182,10 @@ pub fn (mut c Checker) cast_expr(mut node ast.CastExpr) table.Type {
} else if node.expr_type == table.none_type { } else if node.expr_type == table.none_type {
type_name := c.table.type_to_str(node.typ) type_name := c.table.type_to_str(node.typ)
c.error('cannot cast `none` to `$type_name`', node.pos) c.error('cannot cast `none` to `$type_name`', node.pos)
} else if from_type_sym.kind == .struct_ && !node.expr_type.is_ptr() && to_type_sym.kind !in
[.sum_type, .interface_] && !c.is_builtin_mod {
type_name := c.table.type_to_str(node.typ)
c.error('cannot cast `struct` to `$type_name`', node.pos)
} }
if node.has_arg { if node.has_arg {
c.expr(node.arg) c.expr(node.arg)

63
vlib/v/checker/tests/struct_type_cast_err.out 100644
View File

@ -0,0 +1,63 @@
vlib/v/checker/tests/struct_type_cast_err.vv:5:10: error: cannot cast `struct` to `string`
3 | fn main() {
4 | foo := Foo{}
5 | _ := string(foo)
| ~~~~~~~~~~~
6 | _ := int(foo)
7 | _ := u64(foo)
vlib/v/checker/tests/struct_type_cast_err.vv:6:10: error: cannot cast `struct` to `int`
4 | foo := Foo{}
5 | _ := string(foo)
6 | _ := int(foo)
| ~~~~~~~~
7 | _ := u64(foo)
8 | _ := u32(foo)
vlib/v/checker/tests/struct_type_cast_err.vv:7:10: error: cannot cast `struct` to `u64`
5 | _ := string(foo)
6 | _ := int(foo)
7 | _ := u64(foo)
| ~~~~~~~~
8 | _ := u32(foo)
9 | _ := rune(foo)
vlib/v/checker/tests/struct_type_cast_err.vv:8:10: error: cannot cast `struct` to `u32`
6 | _ := int(foo)
7 | _ := u64(foo)
8 | _ := u32(foo)
| ~~~~~~~~
9 | _ := rune(foo)
10 | _ := byte(foo)
vlib/v/checker/tests/struct_type_cast_err.vv:9:10: error: cannot cast `struct` to `rune`
7 | _ := u64(foo)
8 | _ := u32(foo)
9 | _ := rune(foo)
| ~~~~~~~~~
10 | _ := byte(foo)
11 | _ := i8(foo)
vlib/v/checker/tests/struct_type_cast_err.vv:10:10: error: cannot cast type `Foo` to `byte`
8 | _ := u32(foo)
9 | _ := rune(foo)
10 | _ := byte(foo)
| ~~~~~~~~~
11 | _ := i8(foo)
12 | _ := i64(foo)
vlib/v/checker/tests/struct_type_cast_err.vv:11:10: error: cannot cast `struct` to `i8`
9 | _ := rune(foo)
10 | _ := byte(foo)
11 | _ := i8(foo)
| ~~~~~~~
12 | _ := i64(foo)
13 | _ := int(foo)
vlib/v/checker/tests/struct_type_cast_err.vv:12:10: error: cannot cast `struct` to `i64`
10 | _ := byte(foo)
11 | _ := i8(foo)
12 | _ := i64(foo)
| ~~~~~~~~
13 | _ := int(foo)
14 | }
vlib/v/checker/tests/struct_type_cast_err.vv:13:10: error: cannot cast `struct` to `int`
11 | _ := i8(foo)
12 | _ := i64(foo)
13 | _ := int(foo)
| ~~~~~~~~
14 | }
15 |

15
vlib/v/checker/tests/struct_type_cast_err.vv 100644
View File

@ -0,0 +1,15 @@
struct Foo{}
fn main() {
foo := Foo{}
_ := string(foo)
_ := int(foo)
_ := u64(foo)
_ := u32(foo)
_ := rune(foo)
_ := byte(foo)
_ := i8(foo)
_ := i64(foo)
_ := int(foo)
}