From e07869af91fa945d1f03dc083f0db0cdc265b3a6 Mon Sep 17 00:00:00 2001 From: spaceface777 Date: Tue, 19 May 2020 13:17:03 +0200 Subject: [PATCH] builder: fix false-positive import cycle warning --- vlib/v/builder/builder.v | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vlib/v/builder/builder.v b/vlib/v/builder/builder.v index 9d0ae9e81d..8d82b3364e 100644 --- a/vlib/v/builder/builder.v +++ b/vlib/v/builder/builder.v @@ -95,9 +95,9 @@ pub fn (mut b Builder) parse_imports() { pub fn (mut b Builder) resolve_deps() { graph := b.import_graph() deps_resolved := graph.resolve() - is_main_to_builtin := deps_resolved.nodes.len == 1 && deps_resolved.nodes[0].name == 'main' && deps_resolved.nodes[0].deps.len == 1 && deps_resolved.nodes[0].deps[0] == 'builtin' - if !deps_resolved.acyclic && !is_main_to_builtin { - eprintln('warning: import cycle detected between the following modules: \n' + deps_resolved.display_cycles()) + cycles := deps_resolved.display_cycles() + if cycles.len > 1 { + eprintln('warning: import cycle detected between the following modules: \n' + cycles) // TODO: error, when v itself does not have v.table -> v.ast -> v.table cycles anymore return }