vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

smtp_test: use `assert false return`, remove for loop

pull/5824/head
Delyan Angelov 2020-07-13 18:52:46 +03:00
parent 97d01a5487
commit e3f7681e89
1 changed files with 16 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
vlib/net/smtp/smtp_test.v
View File

@ -29,23 +29,20 @@ fn test_smtp() {
body: 'Plain text' body: 'Plain text'
} }
// This loop avoids `or { assert false return }` after each call; instead, it's replaced with mut client := smtp.new_client(client_cfg) or { assert false return }
// `break`. There's an `assert false` after the loop, which will only be called if this loop assert true
// is broken from. client.send(send_cfg) or { assert false return }
for { assert true
mut client := smtp.new_client(client_cfg) or { assert false break } // client.send({ send_cfg | body_type: .html, body: '<html><h1>HTML V email!</h1></html>' }) or { assert false return }
client.send(send_cfg) or { assert false break } client.send({ send_cfg | from: 'alexander@vlang.io' }) or { assert false return }
// client.send({ send_cfg | body_type: .html, body: '<html><h1>HTML V email!</h1></html>' }) or { break } client.send({ send_cfg | cc: 'alexander@vlang.io,joe@vlang.io', bcc: 'spytheman@vlang.io' }) or { assert false return }
client.send({ send_cfg | from: 'alexander@vlang.io' }) or { assert false break } client.send({ send_cfg | date: time.now().add_days(1000) }) or { assert false return }
client.send({ send_cfg | cc: 'alexander@vlang.io,joe@vlang.io', bcc: 'spytheman@vlang.io' }) or { assert false break } assert true
client.send({ send_cfg | date: time.now().add_days(1000) }) or { assert false break } client.quit() or { assert false return }
client.quit() or { assert false break } assert true
// This call should return an error, since the connection is closed // This call should return an error, since the connection is closed
if !fn_errors(client, send_cfg) { assert false break } if !fn_errors(client, send_cfg) { assert false return }
client.reconnect() or { assert false break } client.reconnect() or { assert false return }
client.send(send_cfg) or { assert false break } client.send(send_cfg) or { assert false return }
assert true assert true
return
}
assert false
} }