ci: require code to be formatted before everything else (minimise CI queue length) (#14396)

.github/workflows/ci.yml

@@ -1,12 +1,10 @@
 name: Code CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 concurrency:
   group: build-ci-${{ github.event.pull_request.number || github.sha }}
@@ -33,7 +31,6 @@ jobs:
         run: |
           echo $VFLAGS
           make
-          ./v test-cleancode
           ./v -d debug_malloc -d debug_realloc -o v cmd/v
           ./v -cg -cstrict -o v cmd/v
           # Test v -realloc arena allocation

.github/workflows/ci_bootstrapping_works.yml

@@ -1,12 +1,10 @@
 name: Bootstraping works
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 jobs:
   ubuntu:

.github/workflows/ci_cross.yml

@@ -1,12 +1,10 @@
 name: Cross CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 jobs:
 

.github/workflows/ci_sanitized.yml

@@ -13,6 +13,7 @@ name: Sanitized CI
 
 on:
   push:
+    branches: [master]
     paths:
       - '!**'
       - 'cmd/tools/vtest*'
@@ -72,7 +73,24 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  code-formatting-before-regression:
+    runs-on: ubuntu-20.04
+    timeout-minutes: 15
+    env:
+      VFLAGS: -cc gcc
+    steps:
+      - uses: actions/checkout@v2
+      - name: Environment info
+        run: echo $VFLAGS $GITHUB_SHA $GITHUB_REF
+      - name: Build local v
+        run: make -j4
+      - name: v test-cleancode
+        run: ./v test-cleancode
+      - name: v test-fmt
+        run: ./v test-fmt
+
   tests-sanitize-undefined-clang:
+    needs: [code-formatting-before-regression]
     runs-on: ubuntu-20.04
     timeout-minutes: 180
     env:
@@ -91,13 +109,14 @@ jobs:
           sudo apt-get install --quiet -y libfreetype6-dev  libxi-dev libxcursor-dev libgl-dev
           sudo apt-get install clang
       - name: Build V
-        run: make -j4 && ./v -cg -cstrict -o v cmd/v && ./v test-cleancode
+        run: make -j4 && ./v -cg -cstrict -o v cmd/v
       - name: Self tests (-fsanitize=undefined)
         run: ./v -cflags "-fsanitize=undefined" -o v2 cmd/v && ./v2 -cflags -fsanitize=undefined test-self
       - name: Build examples (V compiled with -fsanitize=undefined)
         run: ./v2 build-examples
 
   tests-sanitize-undefined-gcc:
+    needs: [code-formatting-before-regression]
     runs-on: ubuntu-20.04
     timeout-minutes: 180
     env:
@@ -115,13 +134,14 @@ jobs:
           sudo apt-get install --quiet -y postgresql libpq-dev libssl-dev sqlite3 libsqlite3-dev valgrind
           sudo apt-get install --quiet -y libfreetype6-dev  libxi-dev libxcursor-dev libgl-dev
       - name: Build V
-        run: make -j4 && ./v -cg -cstrict -o v cmd/v && ./v test-cleancode
+        run: make -j4 && ./v -cg -cstrict -o v cmd/v
       - name: Self tests (-fsanitize=undefined)
         run: ./v -cflags "-fsanitize=undefined" -o v2 cmd/v && ./v2 -cflags -fsanitize=undefined test-self
       - name: Build examples (V compiled with -fsanitize=undefined)
         run: ./v2 build-examples
 
   tests-sanitize-address-clang:
+    needs: [code-formatting-before-regression]
     runs-on: ubuntu-20.04
     timeout-minutes: 180
     env:
@@ -140,7 +160,7 @@ jobs:
           sudo apt-get install --quiet -y libfreetype6-dev  libxi-dev libxcursor-dev libgl-dev
           sudo apt-get install clang
       - name: Build V
-        run: make -j4 && ./v -cg -cstrict -o v cmd/v && ./v test-cleancode
+        run: make -j4 && ./v -cg -cstrict -o v cmd/v
       - name: Self tests (-fsanitize=address)
         run: ASAN_OPTIONS=detect_leaks=0 ./v -cflags "-fsanitize=address,pointer-compare,pointer-subtract" test-self
       - name: Self tests (V compiled with -fsanitize=address)
@@ -151,6 +171,7 @@ jobs:
         run: ASAN_OPTIONS=detect_leaks=0 ./v build-examples
 
   tests-sanitize-address-msvc:
+    needs: [code-formatting-before-regression]
     runs-on: windows-2019
     timeout-minutes: 180
     env:
@@ -178,6 +199,7 @@ jobs:
       ##          .\v.exe -cflags "/fsanitize=address" test-self
 
   tests-sanitize-address-gcc:
+    needs: [code-formatting-before-regression]
     runs-on: ubuntu-20.04
     timeout-minutes: 180
     env:
@@ -196,7 +218,7 @@ jobs:
           sudo apt-get install --quiet -y libfreetype6-dev  libxi-dev libxcursor-dev libgl-dev
           sudo apt-get install clang
       - name: Build V
-        run: make -j4 && ./v -cg -cstrict -o v cmd/v && ./v test-cleancode
+        run: make -j4 && ./v -cg -cstrict -o v cmd/v &&
       - name: Self tests (-fsanitize=address)
         run: ASAN_OPTIONS=detect_leaks=0 ./v -cflags -fsanitize=address test-self
       - name: Self tests (V compiled with -fsanitize=address)
@@ -207,6 +229,7 @@ jobs:
         run: ASAN_OPTIONS=detect_leaks=0 ./v build-examples
 
   tests-sanitize-memory-clang:
+    needs: [code-formatting-before-regression]
     runs-on: ubuntu-20.04
     timeout-minutes: 180
     env:
@@ -225,7 +248,7 @@ jobs:
           sudo apt-get install --quiet -y libfreetype6-dev  libxi-dev libxcursor-dev libgl-dev
           sudo apt-get install clang
       - name: Build V
-        run: make -j4 && ./v -cc clang -cg -cstrict -o v cmd/v && ./v test-cleancode
+        run: make -j4 && ./v -cc clang -cg -cstrict -o v cmd/v
       - name: Self tests (-fsanitize=memory)
         run: ./v -cflags -fsanitize=memory test-self
       - name: Self tests (V compiled with -fsanitize=memory)

.github/workflows/ci_v_benchmark.yml

@@ -1,12 +1,10 @@
 name: vlang benchmarks
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 jobs:
   run:

.github/workflows/containers_ci.yml

@@ -1,12 +1,10 @@
 name: Containers CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 concurrency:
   group: build-containers-${{ github.event.pull_request.number || github.sha }}

.github/workflows/docs_ci.yml

@@ -2,7 +2,11 @@ name: Docs CI
 
 ### Run on *EVERY* commit. The documentation *SHOULD* stay valid, and
 ### the developers should receive early warning if they break it.
-on: [push, pull_request]
+on:
+  workflow_run:
+    workflows: ["Other CI"]
+    types:
+      - completed
 
 jobs:
   check-markdown:

.github/workflows/gfx_ci.yml

@@ -1,12 +1,10 @@
 name: Graphics CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 jobs:
   gg-regressions:

.github/workflows/other_ci.yml

@@ -2,6 +2,8 @@ name: Other CI
 
 on:
   push:
+    branches:
+      - master
     paths-ignore:
       - "**.md"
   pull_request:
@@ -14,6 +16,7 @@ concurrency:
 
 jobs:
   no-gpl-by-accident:
+    needs: [code-formatting]
     runs-on: ubuntu-20.04
     timeout-minutes: 15
     steps:
@@ -39,6 +42,7 @@ jobs:
         run: ./v test-fmt
 
   performance-regressions:
+    needs: [code-formatting]
     runs-on: ubuntu-20.04
     timeout-minutes: 15
     env:
@@ -63,6 +67,7 @@ jobs:
         run: cmd/tools/repeat --max_time 1501 --series 3 --count 20 --nmins 2 --nmaxs 5 --warmup 3 --fail_percent 10 -t 'cd {T} ; ./v -show-timings -o v.c cmd/v' . ./vmaster
 
   misc-tooling:
+    needs: [code-formatting]
     runs-on: ubuntu-20.04
     timeout-minutes: 121
     env:
@@ -111,6 +116,7 @@ jobs:
           ./v should-compile-all examples/sokol/*.v examples/sokol/0?*/*.v
 
   parser-silent:
+    needs: [code-formatting]
     runs-on: ubuntu-20.04
     timeout-minutes: 121
     steps:

.github/workflows/paths_ci.yml

@@ -1,12 +1,10 @@
 name: Path Testing CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 concurrency:
   group: build-paths-${{ github.event.pull_request.number || github.sha }}

.github/workflows/sdl_ci.yml

@@ -1,12 +1,10 @@
 name: sdl CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 jobs:
   v-compiles-sdl-examples:

.github/workflows/toml_ci.yml

@@ -1,12 +1,10 @@
 name: toml CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 jobs:
   toml-module-pass-external-test-suites:

.github/workflows/v_apps_and_modules_compile.yml

@@ -1,12 +1,10 @@
 name: V Apps and Modules
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 concurrency:
   group: build-other-${{ github.event.pull_request.number || github.sha }}

.github/workflows/vab_ci.yml

@@ -1,12 +1,10 @@
 name: vab CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 jobs:
   vab-compiles-v-examples:

.github/workflows/vinix-kernel.yml

@@ -1,14 +1,10 @@
 name: Build Vinix kernel
 
 on:
-  pull_request:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  push:
+      - completed
-    branches:
-      - master
-    paths-ignore:
-      - "**.md"
 
 jobs:
   vinix-build:

.github/workflows/websockets.yml

@@ -1,12 +1,10 @@
 name: Websockets CI
 
 on:
-  push:
+  workflow_run:
-    paths-ignore:
+    workflows: ["Other CI"]
-      - "**.md"
+    types:
-  pull_request:
+      - completed
-    paths-ignore:
-      - "**.md"
 
 jobs:
   websocket_tests: