vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

checker: add `1/0x0 1/0b0..` division by zero check (#5694)

pull/5654/head^2
yuyi 2020-07-06 18:32:00 +08:00 committed by GitHub
parent 1d10b150c5
commit f41edef4c6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 39 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
vlib/v/checker/checker.v
View File

@ -552,11 +552,20 @@ pub fn (mut c Checker) infix_expr(mut infix_expr ast.InfixExpr) table.Type {
} }
} }
if infix_expr.op in [.div, .mod] { if infix_expr.op in [.div, .mod] {
if (infix_expr.right is ast.IntegerLiteral && match infix_expr.right as infix_right {
infix_expr.right.str() == '0') || ast.FloatLiteral {
(infix_expr.right is ast.FloatLiteral && infix_expr.right.str().f64() == 0.0) { if infix_right.val.f64() == 0.0 {
oper := if infix_expr.op == .div { 'division' } else { 'modulo' } oper := if infix_expr.op == .div { 'division' } else { 'modulo' }
c.error('$oper by zero', right_pos) c.error('$oper by zero', infix_right.pos)
}
}
ast.IntegerLiteral {
if infix_right.val.int() == 0 {
oper := if infix_expr.op == .div { 'division' } else { 'modulo' }
c.error('$oper by zero', infix_right.pos)
}
}
else {}
} }
} }
return_type = promoted_type return_type = promoted_type

23
vlib/v/checker/tests/division_by_zero_int_err.out
View File

@ -2,4 +2,25 @@ vlib/v/checker/tests/division_by_zero_int_err.v:2:12: error: division by zero
1 | fn main() { 1 | fn main() {
2 | println(1/0) 2 | println(1/0)
| ^ | ^
3 | } 3 | println(1/0x0)
4 | println(1/0b0)
vlib/v/checker/tests/division_by_zero_int_err.v:3:12: error: division by zero
1 | fn main() {
2 | println(1/0)
3 | println(1/0x0)
| ~~~
4 | println(1/0b0)
5 | println(1/0o0)
vlib/v/checker/tests/division_by_zero_int_err.v:4:12: error: division by zero
2 | println(1/0)
3 | println(1/0x0)
4 | println(1/0b0)
| ~~~
5 | println(1/0o0)
6 | }
vlib/v/checker/tests/division_by_zero_int_err.v:5:12: error: division by zero
3 | println(1/0x0)
4 | println(1/0b0)
5 | println(1/0o0)
| ~~~
6 | }

3
vlib/v/checker/tests/division_by_zero_int_err.vv
View File

@ -1,3 +1,6 @@
fn main() { fn main() {
println(1/0) println(1/0)
println(1/0x0)
println(1/0b0)
println(1/0o0)
} }