vieter-v
/
v
2
0
Fork 0
Code Issues Pull Requests Releases Activity

checker: check error for array.index() argument (#14147)

master
yuyi 2022-04-25 19:42:31 +08:00 committed by GitHub
parent aeba110d01
commit f89c81087b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 52 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
vlib/v/checker/fn.v
View File

@ -1946,6 +1946,14 @@ fn (mut c Checker) array_builtin_method_call(mut node ast.CallExpr, left_type as
}
node.return_type = ast.bool_type
} else if method_name == 'index' {
if node.args.len != 1 {
c.error('`.index()` expected 1 argument, but got $node.args.len', node.pos)
} else if !left_sym.has_method('index') {
arg_typ := c.expr(node.args[0].expr)
c.check_expected_call_arg(arg_typ, elem_typ, node.language, node.args[0]) or {
c.error('$err.msg() in argument 1 to `.index()`', node.args[0].pos)
}
}
node.return_type = ast.int_type
} else if method_name in ['first', 'last', 'pop'] {
if node.args.len != 0 {

35
vlib/v/checker/tests/array_index_args_err.out 100644
View File

@ -0,0 +1,35 @@
vlib/v/checker/tests/array_index_args_err.vv:3:23: error: cannot use `[]int` as `int` in argument 1 to `.index()`
1 | fn main() {
2 | arr := [0]
3 | mut ret := [0].index([0])
| ~~~
4 | ret = [0].index()
5 | ret = [0, 1, 2].index(0, 1, 2)
vlib/v/checker/tests/array_index_args_err.vv:4:12: error: `.index()` expected 1 argument, but got 0
2 | arr := [0]
3 | mut ret := [0].index([0])
4 | ret = [0].index()
| ~~~~~~~
5 | ret = [0, 1, 2].index(0, 1, 2)
6 | ret = [0].index('a')
vlib/v/checker/tests/array_index_args_err.vv:5:18: error: `.index()` expected 1 argument, but got 3
3 | mut ret := [0].index([0])
4 | ret = [0].index()
5 | ret = [0, 1, 2].index(0, 1, 2)
| ~~~~~~~~~~~~~~
6 | ret = [0].index('a')
7 | ret = [0].index(arr)
vlib/v/checker/tests/array_index_args_err.vv:6:18: error: cannot use `string` as `int` in argument 1 to `.index()`
4 | ret = [0].index()
5 | ret = [0, 1, 2].index(0, 1, 2)
6 | ret = [0].index('a')
| ~~~
7 | ret = [0].index(arr)
8 | println(ret)
vlib/v/checker/tests/array_index_args_err.vv:7:18: error: cannot use `[]int` as `int` in argument 1 to `.index()`
5 | ret = [0, 1, 2].index(0, 1, 2)
6 | ret = [0].index('a')
7 | ret = [0].index(arr)
| ~~~
8 | println(ret)
9 | }

9
vlib/v/checker/tests/array_index_args_err.vv 100644
View File

@ -0,0 +1,9 @@
fn main() {
arr := [0]
mut ret := [0].index([0])
ret = [0].index()
ret = [0, 1, 2].index(0, 1, 2)
ret = [0].index('a')
ret = [0].index(arr)
println(ret)
}