Add setting for concurrent builds #110
Labels
No Label
Roadmap
V
bug
docs
duplicate
enhancement
good first issue
help wanted
idea
invalid
question
wontfix
Idea
Roadmap
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vieter-v/vieter#110
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
I suggest an env var,
VIETER_MAX_CONCURRENT_BUILDS
, which sets how many builds can be running at once. Implementation should be fairly simple:we currently already have a for loop that checks every 5s whether the build container has finished. This could be expanded to make it check for multiple containers, and at the start of each iteration, we check whether there's a new spot free. Because the check itself is synchronous, no issues should arise from changing the same variable concurrently.
I added this setting when I wrote the cron implementation, as it fit it nicely without any further midifications.