Add setting for concurrent builds #110

Closed
opened 2022-02-27 09:22:18 +01:00 by Jef Roosens · 1 comment

I suggest an env var, VIETER_MAX_CONCURRENT_BUILDS, which sets how many builds can be running at once. Implementation should be fairly simple:

we currently already have a for loop that checks every 5s whether the build container has finished. This could be expanded to make it check for multiple containers, and at the start of each iteration, we check whether there's a new spot free. Because the check itself is synchronous, no issues should arise from changing the same variable concurrently.

I suggest an env var, `VIETER_MAX_CONCURRENT_BUILDS`, which sets how many builds can be running at once. Implementation should be fairly simple: we currently already have a for loop that checks every 5s whether the build container has finished. This could be expanded to make it check for multiple containers, and at the start of each iteration, we check whether there's a new spot free. Because the check itself is synchronous, no issues should arise from changing the same variable concurrently.
Jef Roosens added this to the 0.2.0 milestone 2022-02-27 09:22:18 +01:00
Jef Roosens added the
enhancement
label 2022-02-27 09:22:18 +01:00
Jef Roosens modified the milestone from 0.2.0 to 0.3.0 2022-03-29 13:48:50 +02:00
Jef Roosens modified the milestone from 0.3.0 to 0.4.0 2022-04-20 09:53:22 +02:00
Jef Roosens modified the milestone from 0.4.0 to 0.3.0 2022-05-02 15:41:41 +02:00

I added this setting when I wrote the cron implementation, as it fit it nicely without any further midifications.

I added this setting when I wrote the cron implementation, as it fit it nicely without any further midifications.
Sign in to join this conversation.
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vieter-v/vieter#110
There is no content yet.