Add setting for concurrent builds #110
Labels
No labels
Roadmap
V
bug
docs
duplicate
enhancement
good first issue
help wanted
idea
invalid
question
wontfix
Idea
Roadmap
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No project
No assignees
1 participant
Due date
No due date set.
Dependencies
No dependencies set.
Reference: vieter-v/vieter#110
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I suggest an env var,
VIETER_MAX_CONCURRENT_BUILDS, which sets how many builds can be running at once. Implementation should be fairly simple:we currently already have a for loop that checks every 5s whether the build container has finished. This could be expanded to make it check for multiple containers, and at the start of each iteration, we check whether there's a new spot free. Because the check itself is synchronous, no issues should arise from changing the same variable concurrently.
I added this setting when I wrote the cron implementation, as it fit it nicely without any further midifications.