Refactor docker code #170

New issue

Closed

opened 2022-05-08 00:10:54 +02:00 by Jef Roosens · 1 comment

Jef Roosens commented

2022-05-08 00:10:54 +02:00

Owner

I gotta admit, the Docker daemon code is kinda shit. It could use a proper refactor, which we also need so we can then more easily retrieve the logs of a container.

Jef Roosens added this to the 0.3.0 milestone 2022-05-08 00:10:54 +02:00

Jef Roosens added the

enhancement

label 2022-05-08 00:10:54 +02:00

Jef Roosens commented

2022-05-10 12:31:59 +02:00

Author

Owner

Another idea I just had, perhaps we re-write the code so that it behaves more like a BufferedReader object. This would prevent us from ever having to load anything completely into memory unless absolutely required, as we could create a chain of stream operations. Perhaps by adding a way to append to a build log using the web API, we could prevent having to load the entire logs into memory at all.

Jef Roosens referenced this issue from a pull request that will close it,

2022-05-16 13:43:21 +02:00

Full Docker code refactor #183

Jef Roosens closed this issue

2022-05-16 15:44:36 +02:00

This repository is archived. You cannot comment on issues.