Switched to Black-focused config

pull/2/head
Jef Roosens 2021-05-22 21:28:01 +02:00
parent e044c07cd6
commit 11e5ee2869
Signed by: Jef Roosens
GPG Key ID: 955C0660072F691F
10 changed files with 21 additions and 16 deletions

View File

@ -1,5 +1,6 @@
# vim: ft=cfg
[flake8]
max-line-length = 88
max-complexity = 7
docstring-convention=google

View File

@ -4,7 +4,7 @@ PYTHON := python3
VENV := .venv
# Minimum % coverage for tests to succeed
MIN_COV := 50
SRC := setup.py app tests
SRC := setup.py config_skeleton tests
# =====GENERAL=====
@ -34,18 +34,19 @@ venv: $(VENV)/bin/activate
## Formatting & linting
### Format the codebase using black
format: venv
@ '$(VENV)'/bin/black $(SRC)
@ '$(VENV)'/bin/isort $(SRC)
@ '$(VENV)'/bin/black $(SRC)
.PHONY: format
### Lint using black & flake8
lint: venv
@ '$(VENV)'/bin/flake8 $(SRC)
@ '$(VENV)'/bin/black --check $(SRC)
@ '$(VENV)'/bin/isort --check $(SRC)
.PHONY: lint
## Testing
test: venv
@ '$(VENV)'/bin/pytest --cov=app --cov-fail-under='$(MIN_COV)' tests/
@ '$(VENV)'/bin/pytest --cov=config_skeleton --cov-fail-under='$(MIN_COV)' tests/
.PHONY: test

View File

@ -1 +0,0 @@
"""Main module for the app."""

View File

@ -0,0 +1,11 @@
"""Main module for the app."""
from .exceptions import InvalidKeyError, InvalidValueError, MissingKeyError
from .skeleton import merge, merge_with_skeleton
__all__ = [
"InvalidKeyError",
"InvalidValueError",
"MissingKeyError",
"merge",
"merge_with_skeleton",
]

View File

@ -48,8 +48,7 @@ class InvalidValueError(Exception):
actual: name of the actual type
"""
self.message = (
f"Invalid value for key {key}: expected {expected}, "
f"got {actual}"
f"Invalid value for key {key}: expected {expected}, " f"got {actual}"
)
super().__init__()

View File

@ -37,9 +37,7 @@ def merge(*dicts: [Dict]) -> Dict:
if type(value) == dict:
# Merge the two sub-dictionaries
output[key] = (
merge(output[key], value)
if type(output.get(key)) == dict
else value
merge(output[key], value) if type(output.get(key)) == dict else value
)
else:

View File

@ -2,9 +2,6 @@
requires = ["setuptools", "wheel"]
build-backend = "setuptools.build_meta"
[tool.black]
line-length = 79
[tool.isort]
profile = "black"
multi_line_output = 3

View File

@ -3,7 +3,7 @@ name = config-skeleton
version = 0.0.1
[options]
packages = app
packages = config_skeleton
install_requires =
[options.extras_require]

View File

@ -1,5 +1,5 @@
"""Tests for the skeleton module."""
from app.skeleton import merge
from config_skeleton import merge
def test_merge_empty():

View File

@ -1,8 +1,7 @@
"""Tests wether the skeleton merge works."""
import pytest
from app.exceptions import InvalidKeyError, MissingKeyError
from app.skeleton import merge_with_skeleton
from config_skeleton import InvalidKeyError, MissingKeyError, merge_with_skeleton
def test_single_invalid_key():