Chewing_Bever/fej
Archived
1
0
Fork 0
Code Issues 28 Pull requests 10 Projects 3 Releases 4 Wiki Activity

Ivago: invalid parameters also return 404 #11

Open
opened 2021-04-04 15:25:48 +02:00 by Jef Roosens · 2 comments
Jef Roosens commented 2021-04-04 15:25:48 +02:00
Owner
Copy link

When visiting the following URL:

https://fej.roosens.me/ivago?street=Lange+Violettestraat+(GENT)&number=170&start_date=2021-04-04&end_date=2021-04-255

Instead of responding with a Bad Request error, it returns the default 404 handler.

Update:

The problem is now that we don't really have a way to detect wether a route failed because it doesn't exist or because its parameters weren't correct.

When visiting the following URL: `https://fej.roosens.me/ivago?street=Lange+Violettestraat+(GENT)&number=170&start_date=2021-04-04&end_date=2021-04-255` Instead of responding with a Bad Request error, it returns the default 404 handler. Update: The problem is now that we don't really have a way to detect wether a route failed because it doesn't exist or because its parameters weren't correct.
Jef Roosens added this to the (deleted) project 2021-04-04 15:25:48 +02:00
Jef Roosens commented 2021-04-04 18:59:10 +02:00
Author
Owner
Copy link

I just realized this is expected behavior. The real problem here is the fact that the error system isn't specific enough at the moment, so any typo in a parameter results in a 404, instead of a meaningful message.

I just realized this is expected behavior. The real problem here is the fact that the error system isn't specific enough at the moment, so any typo in a parameter results in a 404, instead of a meaningful message.
Jef Roosens changed title from Ivago: invalid parameter errors aren't handled properly to Ivago: invalid parameter also return 404 2021-04-04 19:11:40 +02:00
Jef Roosens removed this from the (deleted) project 2021-04-04 19:12:22 +02:00
Jef Roosens changed title from Ivago: invalid parameter also return 404 to Ivago: invalid parameters also return 404 2021-04-05 10:06:11 +02:00
Jef Roosens commented 2021-04-14 23:25:02 +02:00
Author
Owner
Copy link

I think we can use a fairing to check the error type on response.

I think we can use a fairing to check the error type on response.
Commenting is not possible because the repository is archived.
No Branch/Tag specified
Branches Tags
develop
renovate/reqwest-0.x
renovate/serde-1.x
renovate/eslint-plugin-vue-8.x
renovate/vitejs-plugin-vue-2.x
renovate/typescript-eslint-parser-5.x
renovate/typescript-eslint-eslint-plugin-5.x
renovate/vue-tsc-0.x
renovate/chrono-tz-0.x
renovate/eslint-plugin-promise-6.x
renovate/alpine-3.x
68-clippy
master
v1.0.2
v1.0.1
v1.0.0
v0.1.0
Labels
Clear labels   
Brainstorm
Place to brainstorm problems or possible ideas

  
Parent
Description of larger problem with multiple issues

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
idea
A possible idea for a feature

  
invalid
Something is wrong

  
project/backend
An issue related to the backend

  
project/frontend
An issue related to the frontend

  
question
More information is needed

  
wontfix
This won't be fixed

No labels
Brainstorm
Parent
bug
duplicate
enhancement
help wanted
idea
invalid
project/backend
project/frontend
question
wontfix
Milestone
Clear milestone
No items
Projects
Clear projects
No items
No project
Fej 1.1.0
Assignees
Clear assignees
No assignees
Jef Roosens
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#39 Improve handling of errors
Chewing_Bever/fej
Reference
Chewing_Bever/fej#11
No description provided.