Improve handling of errors #39

New issue

Open

opened 2021-04-22 12:14:52 +02:00 by Jef Roosens · 0 comments

Jef Roosens commented

2021-04-22 12:14:52 +02:00

Owner

At the moment, we just convert every type of error into a FejError object, but this approaches isn't as flexible when it comes to defining verbose error messages.

As an alternative, could define FejError like this:

pub enum FejError {
	ReqwestError(reqwest::Error),
    DatabaseError(diesel::result::Error),
}

We can then define a From<reqwest::Error> for Status for each wrapped type (reqwest::Error is just an example here). This way, we have full control over what each error represents when returning a Status.

As a bonus, we can practice writing macros, as this looks like a prime example.

Inspiration for this approach

At the moment, we just convert every type of error into a `FejError` object, but this approaches isn't as flexible when it comes to defining verbose error messages. As an alternative, could define `FejError` like this: ```rust pub enum FejError { ReqwestError(reqwest::Error), DatabaseError(diesel::result::Error), } ``` We can then define a `From<reqwest::Error> for Status` for each wrapped type (`reqwest::Error` is just an example here). This way, we have full control over what each error represents when returning a Status. As a bonus, we can practice writing macros, as this looks like a prime example. [Inspiration for this approach](https://edgarluque.com/blog/wrapping-errors-in-rust)