Jef Roosens Chewing_Bever
Loading Heatmap…

Jef Roosens pushed to red-black-tree at Chewing_Bever/libvieter

2023-02-01 23:24:35 +01:00

Jef Roosens pushed to red-black-tree at Chewing_Bever/libvieter

2023-02-01 23:04:54 +01:00

Jef Roosens synced new reference rewrite-react to Chewing_Bever/didier from mirror

2023-02-01 20:34:55 +01:00

Jef Roosens synced commits to rewrite-react at Chewing_Bever/didier from mirror

2023-02-01 20:34:55 +01:00

Jef Roosens commented on issue vieter-v/vieter#167

Support other database backends

The PR didn't make it into V 0.3.3 🤷‍♂️

2023-01-31 10:03:55 +01:00

Jef Roosens opened issue vieter-v/vieter#345

Investigate possible vweb improvements

2023-01-31 08:40:30 +01:00

Jef Roosens opened issue vieter-v/vieter#344

Update to V 0.3.3

2023-01-30 19:36:43 +01:00

Jef Roosens pushed to red-black-tree at Chewing_Bever/libvieter

  • 17c2e15385 feat(tree): first attempt at wikipedia pseudo code

2023-01-30 12:28:20 +01:00

Jef Roosens pushed to red-black-tree at Chewing_Bever/libvieter

  • 1d458c68a4 feat(tree): start of balanced removal

2023-01-29 21:35:03 +01:00

Jef Roosens pushed to red-black-tree at Chewing_Bever/libvieter

2023-01-29 21:08:41 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

I'm not quite sure yet where I'd like to place third-party code (in case we start adding more stuff like this), but considering this is the only place this is used, just leaving it here for now is fine.

2023-01-29 13:42:07 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

As mentioned on matrix, this function should become a streaming one.

2023-01-29 13:42:07 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

This check is not safe, the dynarray code doesn't make any guarantees about empty fields being NULL, they're simply malloc'ed and not initialised.

2023-01-29 13:42:07 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

I don't personally use this style of free function right now, but it might be interesting to migrate all free functions to this style indeed. I'm assuming the pointer-to-pointer is so you can set the variable containing the pointer to NULL as well?

2023-01-29 13:42:07 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

This should also use `SMALL_BUFF_SIZE` I think, just for consistency.

2023-01-29 13:42:07 +01:00

Jef Roosens suggested changes for vieter-v/libvieter#6

Refactor package module into C

In general, the code isn't formatted at all, but that can be fixed by a simple `make fmt`.

2023-01-29 13:42:07 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

Shouldn't this be `sizeof(a package)`?

2023-01-29 13:42:07 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

Oh smart, no array indexing required, didn't even think of that ;p

2023-01-29 13:42:07 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

Same here

2023-01-29 13:42:07 +01:00

Jef Roosens commented on pull request vieter-v/libvieter#6

Refactor package module into C

General note for `snprintf` usage: what happens if the value is larger than the buffer? Is it simply cut off? Cuz if so, we shouldn't be making assumptions about the length of the input.

2023-01-29 13:42:07 +01:00