- Belgium
- https://www.rustybever.be
-
Computer science student from Belgium who loves playing around with servers.
- Joined on
2021-03-28 -
-
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CI don't personally use this style of free function right now, but it might be interesting to migrate all free functions to this style indeed. I'm assuming the pointer-to-pointer is so you can set the variable containing the pointer to NULL as well?
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CAs mentioned on matrix, this function should become a streaming one.
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CThis check is not safe, the dynarray code doesn't make any guarantees about empty fields being NULL, they're simply malloc'ed and not initialised.
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into COh smart, no array indexing required, didn't even think of that ;p
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CI'm not quite sure yet where I'd like to place third-party code (in case we start adding more stuff like this), but considering this is the only place this is used, just leaving it here for now is fine.
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CThis should also use `SMALL_BUFF_SIZE` I think, just for consistency.
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CShouldn't this be `sizeof(a package)`?
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CReturning `NULL` when a function fails doesn't say anything about why the function failed. A better API imo (which I also use in the heap module) is for the function to return an enum value intead, indicating the success of the function. The output is written to a pointer-to-pointer that is passed as the first argument of the function.
Jef Roosens suggested changes for vieter-v/libvieter#6
Refactor package module into CIn general, the code isn't formatted at all, but that can be fixed by a simple `make fmt`.
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CVieter doesn't only supports zstd-compressed archives. Currently it also accepts xz- or gzip-compressed archives, so this should be accounted for.
Jef Roosens commented on pull request vieter-v/libvieter#6
Refactor package module into CGeneral note for `snprintf` usage: what happens if the value is larger than the buffer? Is it simply cut off? Cuz if so, we shouldn't be making assumptions about the length of the input.
Jef Roosens pushed to red-black-tree at Chewing_Bever/libvieter
-
Jef Roosens pushed to dev at Chewing_Bever/vieter
-
Jef Roosens pushed to dev at vieter-v/vieter
-
Jef Roosens pushed to main at vieter-v/metrics
-
Jef Roosens pushed to main at vieter-v/metrics
-
-
- Compare 2 commits »
Jef Roosens pushed to mem-usage at vieter-v/metrics
-
-
- Compare 2 commits »
Jef Roosens pushed to dev at Chewing_Bever/vieter
-
-
-
-
-
- Compare 10 commits »