cron expression parser #127

Merged

Jef Roosens merged 20 commits from cron into dev 2022-04-12 21:37:03 +02:00

Conversation 1 Commits 20 Files changed 12 +453

Jef Roosens commented 2022-04-12 11:15:22 +02:00

Owner

Copy link

This PR implements a parser for a subset of the cron expression syntax. I want to merge this separately from the actual cron implementation itself because I'd like the testing workflow to be added to dev first. It's also already a rather big PR, so making it any bigger would not be a good idea.

The syntax for the cron expressions are of the form a b c d, where c & d are optional & will be replaced by * if absent. Each of the four parts can be one or multiple (divided using ,) of *, n, n-m, */n, n/m or n-m/o, with n, m & o being positive whole numbers.

I'm keeping this PR in WIP until I've written an adequate amount of tests for both the parser & the 'next occurence' calculation function.

This PR implements a parser for a subset of the cron expression syntax. I want to merge this separately from the actual cron implementation itself because I'd like the testing workflow to be added to dev first. It's also already a rather big PR, so making it any bigger would not be a good idea. The syntax for the cron expressions are of the form `a b c d`, where c & d are optional & will be replaced by `*` if absent. Each of the four parts can be one or multiple (divided using `,`) of `*`, `n`, `n-m`, `*/n`, `n/m` or `n-m/o`, with n, m & o being positive whole numbers. I'm keeping this PR in WIP until I've written an adequate amount of tests for both the parser & the 'next occurence' calculation function.

Jef Roosens added this to the 0.3.0 milestone 2022-04-12 11:15:22 +02:00

Jef Roosens added the

enhancement

label 2022-04-12 11:15:22 +02:00

Jef Roosens added 13 commits 2022-04-12 11:15:23 +02:00

Start of cron implementation 41ee08045b

Ran formatter e890128bda

Started writing cron expression parser [CI SKIP] 6d60ea1538

Gave all modules own directory; added test CI pipeline f92a20fcf8

Added some extra tests for parse_range 799fe2e454

Can't figure out cron algo right now [CI SKIP] e3da3d0d7f

Alpha version cron 'next' function 135b6c3d7f

Added some much-needed documentation 0e5f31e649

Failed attempt at x,y,z cron stuff [CI SKIP] ab4f64b6b6

Migrated tests to new bitv-based implementation 04e54b8b10

Tests n bug fixes f4bb03f488

Added support for x-y syntax 2942793f40

Made sure unix value is calculated 65d6aae701

Jef Roosens added 14 commits 2022-04-12 11:30:25 +02:00

Merge pull request 'Release 0.1.0' (#65) from dev into main ... dec2e9d759

Reviewed-on: Chewing_Bever/vieter#65

Added route to request desc file; updated builder for new route (fixes #118) ebe01c2d44

Each repo now has its own subdir in pkg_dir cec5ecce7f

Solved the "removing old packages" problem (I think) a65207f961

Updated changelog 62bee78955

Merge pull request 'Old packages are now removed properly' (#120) from remove-old-packages into dev ... 8e7d3508d2

Reviewed-on: Chewing_Bever/vieter#120

Updated README (Closes #68) [CI SKIP] 2d01c5374b

Forgot trailing slash [CI SKIP] ff9ff9bf99

Bumped version in cli aacadca7a8

Merge branch 'main' into release-0.2.0 207344a99d

Updated CHANGELOG [CI SKIP] 7e142cb6c7

Removed unnecessary log output 3b15066329

Merge pull request 'Release 0.2.0' (#121) from release-0.2.0 into main ... 4b6a661d71

Reviewed-on: Chewing_Bever/vieter#121

Merge branch 'dev' into cron 5c38071998

Jef Roosens added 1 commit 2022-04-12 11:37:51 +02:00

Merge branch 'dev' into cron cb22c1c9d3

Jef Roosens added 1 commit 2022-04-12 14:22:54 +02:00

These bugs are gonna take a while eb65bb8a69

Jef Roosens added 1 commit 2022-04-12 20:53:32 +02:00

Ran vfmt e6033f9ab4

Jef Roosens added 1 commit 2022-04-12 21:16:29 +02:00

Actually possibly kinda decent cron next func 1116fee3fc

Jef Roosens added 1 commit 2022-04-12 21:23:55 +02:00

Added two more test dates; pleased v vet 5ce431aa4a

Jef Roosens commented 2022-04-12 21:24:41 +02:00

Author

Owner

Copy link

I'm tempted to merge this PR prematurely. It's a critical part for developing all other parts of the improved builder system, & testing it will take a long time anyways so it might be useful to just do this throughout development of the 0.3.0 release.

I'm tempted to merge this PR prematurely. It's a critical part for developing all other parts of the improved builder system, & testing it will take a long time anyways so it might be useful to just do this throughout development of the 0.3.0 release.

Jef Roosens changed title from WIP: cron expression parser to cron expression parser 2022-04-12 21:24:45 +02:00

Jef Roosens added 1 commit 2022-04-12 21:28:58 +02:00

Added 'WIP' notice for cron cli bd0c276fd8

Jef Roosens merged commit 05b34d3ffd into dev 2022-04-12 21:37:03 +02:00

Jef Roosens referenced this pull request from a commit 2022-04-12 21:37:04 +02:00

Merge pull request 'cron expression parser' (#127) from cron into dev

This repository is archived. You cannot comment on pull requests.

Reviewers

No reviewers

Labels

Clear labels   

Roadmap

Tracking issue for a larger task

  

V

This issue is blocked by a V issue

  

bug

Something is not working

  

docs

Something to add to the documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

good first issue

A good issue to start out with as a new contributor

  

help wanted

Need some help

  

idea

Issue for brainstorming a new idea

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

  

Idea

Issue for brainstorming a new idea

  

Roadmap

Tracking issue for a larger task

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

Roadmap

V

bug

docs

duplicate

enhancement

good first issue

help wanted

idea

invalid

question

wontfix

Idea

Roadmap

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

0.3.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: vieter-v/vieter#127

No description provided.