Full Docker code refactor #183

Merged

Jef Roosens merged 17 commits from Chewing_Bever/vieter:docker-rework into dev 2022-05-16 15:44:36 +02:00

Conversation 0 Commits 17 Files changed 14 +523 -195

Jef Roosens commented 2022-05-16 13:42:48 +02:00

Owner

Copy link

This PR refactores the Docker socket code, adding full support for streams using io.Reader implementations. It also allows re-using a socket connection for multiple requests.

Closes #170

This PR refactores the Docker socket code, adding full support for streams using `io.Reader` implementations. It also allows re-using a socket connection for multiple requests. Closes #170

Jef Roosens added this to the 0.3.0 milestone 2022-05-16 13:42:48 +02:00

Jef Roosens added the

enhancement

label 2022-05-16 13:42:48 +02:00

Jef Roosens added 11 commits 2022-05-16 13:42:49 +02:00

feat(docker): start of new socket implementation 473c7ec06b

refactor: ran vfmt with new defaults ... dd9958ea28

feat(docker): started work on new implementation

feat(docker): partially migrate to new code 4c97489f8a

feat(docker): error when HTTP requests fail da46b8b4ae

feat(docker): added ChunkedResponseReader implementation 92cbea69d6

feat(docker): added StreamFormatReader f22ed29631

doc: documented new Docker code 1811ebbe3f

fix(docker): read_response now handles chunked data 79fd9c1f87

feat(docker): fully migrate build commands to new code e041682fea

refactor(docker): remove old code ce67208fbd

refactor(docker): split stream separator code into own function 97cdaa18e1

Jef Roosens referenced this pull request 2022-05-16 14:32:57 +02:00

Make build functions more error-resilient #149

Jef Roosens referenced this pull request 2022-05-16 14:33:51 +02:00

Logs sometimes aren't sent completely #172

Jef Roosens added 2 commits 2022-05-16 14:42:28 +02:00

refactor(docker): renamed DockerDaemon to DockerConn 1d3c7a1651

refactor(util): split into two files 055b168ff1

Jef Roosens added 1 commit 2022-05-16 14:54:44 +02:00

doc(env): added missing docstring & README d4c803c41c

Jef Roosens added 1 commit 2022-05-16 15:11:40 +02:00

refactor(docker): use http.Method instead of strings 850cba6ab9

Jef Roosens changed title from WIP: full Docker code refactor to full Docker code refactor 2022-05-16 15:11:45 +02:00

Jef Roosens added 2 commits 2022-05-16 15:39:42 +02:00

refactor(docker): more tightly integrate streams 3c87e60293

refactor(docker): removed unused function 889d5a0884

Jef Roosens changed title from full Docker code refactor to Full Docker code refactor 2022-05-16 15:43:25 +02:00

Jef Roosens merged commit 92f73ad364 into dev 2022-05-16 15:44:36 +02:00

Jef Roosens referenced this pull request from a commit 2022-05-16 15:44:36 +02:00

Merge pull request 'Full Docker code refactor' (#183) from Chewing_Bever/vieter:docker-rework into dev

This repository is archived. You cannot comment on pull requests.

Reviewers

No reviewers

Labels

Clear labels   

Roadmap

Tracking issue for a larger task

  

V

This issue is blocked by a V issue

  

bug

Something is not working

  

docs

Something to add to the documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

good first issue

A good issue to start out with as a new contributor

  

help wanted

Need some help

  

idea

Issue for brainstorming a new idea

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

  

Idea

Issue for brainstorming a new idea

  

Roadmap

Tracking issue for a larger task

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

Roadmap

V

bug

docs

duplicate

enhancement

good first issue

help wanted

idea

invalid

question

wontfix

Idea

Roadmap

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

0.3.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: vieter-v/vieter#183

No description provided.