Commit Graph

1158 Commits (a1d3a43940fe3992d70c5eba6390c062bd4d1696)

Author SHA1 Message Date
Jef Roosens a1d3a43940 Switched to make clean for post-checkout hook 2020-12-26 12:49:31 +01:00
Jef Roosens 02213f5f57 Added post-checkout hook to clear build files 2020-12-26 12:47:18 +01:00
Jef Roosens f315834f03 Put pointers in the correct spot 2020-12-26 12:28:34 +01:00
Jef Roosens 8d792bbc50 Fixed clang-format; updated cmakelists 2020-12-26 11:26:08 +01:00
Jef Roosens 39fd726a51 Initial split (non-working) 2020-12-03 15:44:46 +01:00
Jef Roosens 010fb66cb6 Split off utf8 encoding 2020-12-02 16:09:09 +01:00
Jef Roosens 25af8ba5fc Merged stash 2020-12-02 15:07:29 +01:00
Jef Roosens a13536d0c7 Some refactoring 2020-12-02 14:26:01 +01:00
Jef Roosens 1052dd6244 Added correct formatting; started docstrings; added min size rel build 2020-12-02 12:40:21 +01:00
Jef Roosens 32184c498c Added changelog/roadmap 2020-12-01 18:27:35 +01:00
Jef Roosens b6b60550d2 Merge master into develop 2020-12-01 18:02:48 +01:00
Jef Roosens 26f8a1f24d Fixed typos 2020-12-01 16:49:31 +01:00
Jef Roosens e31e5ca3fa Improved README 2020-12-01 16:47:56 +01:00
Jef Roosens 1df9f84dcb Formatted using clang-format 2020-12-01 16:17:46 +01:00
Jef Roosens 47a6d63f6d Merge branch 'develop' 2020-11-14 17:31:23 +01:00
Jef Roosens cbefc58bb0 Added install & uninstall; added desktop entry 2020-11-14 17:30:54 +01:00
Jef Roosens fad6ca04a9 Updated gitignore 2020-11-14 16:38:09 +01:00
Jef Roosens 7c43bcb2d8 Tidied up Makefile; fixed compile commands not generating 2020-11-07 15:29:13 +01:00
Jef Roosens 584bcb94d1 Fixed implicit method; some refactoring 2020-11-07 14:49:29 +01:00
Jef Roosens 66093b4858 Added extra compiler flags 2020-11-06 15:45:41 +01:00
Jef Roosens 209f27d114 Split macros into own header file 2020-11-06 13:33:21 +01:00
Jef Roosens d83fb29d6b Added Makefile cmake wrapper 2020-11-06 13:03:16 +01:00
Jef Roosens 6a203b3fe5 Switched to C11; added release types 2020-11-05 18:21:52 +01:00
--unset 68ce8a3914 Added header guards; fixed linter errors 2020-11-05 18:00:50 +01:00
--unset 9fca78f0dd Changed compiler to clang-10 2020-11-05 17:49:05 +01:00
Jef Roosens 4e5a59b34d Added working CMake build (#1) 2020-11-05 17:02:06 +01:00
Jef Roosens bbca7d0a0f Moved everything to src dir (#1) 2020-11-05 14:00:55 +01:00
Jef Roosens 8a611a85f4 Some re-organizing (#1) 2020-11-05 13:56:01 +01:00
Jef Roosens 80cded6ecf Added .gitignore (#1) 2020-11-05 13:53:13 +01:00
Hiltjo Posthuma 4ef0cbd8b9 remove unused variable from previous patch 2020-10-18 11:18:03 +02:00
John Collis 28b4c822c5 ST: Add WM_ICON_NAME property support
Also added _NET_WM_ICON_NAME.
2020-10-18 11:17:11 +02:00
Hiltjo Posthuma fa253f077f bump version to 0.8.4 2020-06-19 11:27:17 +02:00
Hiltjo Posthuma b27a383a3a config.mk: use PKG_CONFIG in commented OpenBSD section 2020-06-17 23:49:40 +02:00
Hiltjo Posthuma 81067c65ea LICENSE: bump years 2020-06-17 23:49:40 +02:00
Hiltjo Posthuma f74a9df6e1 remove sixel stub code
Remove stub code that was used for an experiment of adding sixel code to st
from the commit f7398434.
2020-06-17 23:49:22 +02:00
Hiltjo Posthuma 818ec746f4 fix unicode glitch in DCS strings, patch by Tim Allen
Reported on the mailinglist:

"
I discovered recently that if an application running inside st tries to
send a DCS string, subsequent Unicode characters get messed up. For
example, consider the following test-case:

    printf '\303\277\033P\033\\\303\277'

...where:

  - \303\277 is the UTF-8 encoding of U+00FF LATIN SMALL LETTER Y WITH
    DIAERESIS (ÿ).
  - \033P is ESC P, the token that begins a DCS string.
  - \033\\ is ESC \, a token that ends a DCS string.
  - \303\277 is the same ÿ character again.

If I run the above command in a VTE-based terminal, or xterm, or
QTerminal, or pterm (PuTTY), I get the output:

    ÿÿ

...which is to say, the empty DCS string is ignored. However, if I run
that command inside st (as of commit 9ba7ecf), I get:

    ÿÿ

...where those last two characters are \303\277 interpreted as ISO8859-1
characters, instead of UTF-8.

I spent some time tracing through the state machines in st.c, and so far
as I can tell, this is how it works currently:

  - ESC P sets the "ESC_DCS" and "ESC_STR" flags, indicating that
    incoming bytes should be collected into the strescseq buffer, rather
    than being interpreted.
  - ESC \ sets the "ESC_STR_END" flag (when ESC is received), and then
    calls strhandle() (when \ is received) to interpret the collected
    bytes.
  - If the collected bytes begin with 'P' (i.e. if this was a DCS
    string) strhandle() sets the "ESC_DCS" flag again, confusing the
    state machine.

If my understanding is correct, fixing the problem should be as easy as
removing the line that sets ESC_DCS from strhandle():

diff --git a/st.c b/st.c
index ef8abd5..b5b805a 100644
--- a/st.c
+++ b/st.c
@@ -1897,7 +1897,6 @@ strhandle(void)
		xsettitle(strescseq.args[0]);
		return;
	case 'P': /* DCS -- Device Control String */
-		term.mode |= ESC_DCS;
	case '_': /* APC -- Application Program Command */
	case '^': /* PM -- Privacy Message */
		return;

I've tried the above patch and it fixes my problem, but I don't know if
it introduces any others.
"
2020-06-17 21:35:39 +02:00
Hiltjo Posthuma 9ba7ecf7b1 FAQ: fix single-buffer patch
rebase against master
2020-06-01 14:09:46 +02:00
Hiltjo Posthuma a2a704492b config.def.h: add an option allowwindowops, by default off (secure)
Similar to the xterm AllowWindowOps option, this is an option to allow or
disallow certain (non-interactive) operations that can be insecure or
exploited.

NOTE: xsettitle() is not guarded by this because st does not support printing
the window title. Else this could be exploitable (arbitrary code execution).
Similar problems have been found in the past in other terminal emulators.

The sequence for base64-encoded clipboard copy is now guarded because it allows
a sequence written to the terminal to manipulate the clipboard of the running
user non-interactively, for example:

printf '\x1b]52;0;ZWNobyBoaQ0=\a'
2020-05-30 22:06:15 +02:00
Hiltjo Posthuma 0f8b40652b FAQ: add some details about the w3m img hack
... and an example patch to switch from double-buffering to a single buffer.
2020-05-30 22:05:17 +02:00
Hiltjo Posthuma e6e2c6199f tiny style fix 2020-05-30 22:05:17 +02:00
Hiltjo Posthuma 94b8ec0021 Partially add back in "support REP (repeat) escape sequence"
Add the functionality back in for xterm compatibility, but do not expose the
capability in st.info (yet).

Some notes:

It was reverted because it caused some issues with ncurses in some
configurations, namely when using BSD padding (--enable-bsdpad, BSD_TPUTS) in
ncurses it caused issues with repeating digits.

A fix has been upstreamed in ncurses since snapshot 20200523. The fix is also
backported to OpenBSD -current.
2020-05-30 22:04:28 +02:00
Steve Ward dec6b530a4 Call xsetcursor to set win.cursor in main
In xsetcursor, remove "DEFAULT(cursor, 1)" because 0 is a valid value.
Increase max allowed value of cursor from 6 to 7 (st extension).
2020-05-24 13:45:42 +02:00
Hiltjo Posthuma 475a0a36cb Revert "support REP (repeat) escape sequence"
This reverts commit e8392b282c.

There is currently a bug in older ncurses versions (like on OpenBSD) where a
fix for a bug with REP is not backported yet. Most likely in tty/tty_update.c:

Noticed while using lynx (which uses ncurses/curses).
To reproduce using lynx: echo "Z0000000" | lynx -stdin

or using the program:

int
main(void)
{
	WINDOW *win;
	win = initscr();

	printw("Z0000000");

	refresh();

	sleep(5);

	return 0;
}

This prints "ZZZZZZZ" (incorrectly).
2020-05-16 21:06:13 +02:00
Avi Halachmi (:avih) e8392b282c support REP (repeat) escape sequence
The sequence \e[Nb prints the last printed char N (more) times if it's
printable, and it's ignored after newline or other control chars.

This is Ecma-048/ANSI-X3.6 sequence and not DEC VT. It's supported by
xterm, and ncurses uses it when possible, e.g. when TERM is xterm* (and
with this commit also st*).

xterm supports only codepoints<=255, possibly due to internal limits.
We support any value/codepoint which was placed in a cell.

To test:
- tput rep 65 4 -> prints 'AAAA'
- printf "\342\225\246\033[4b" -> prints U+2566 1+4 times.
2020-05-16 14:08:10 +02:00
Roberto E. Vargas f8afebdfa0 Add rin terminfo capability
Tianlin Qu discovered that st is missing rin (scroll back #1 lines).
2020-05-16 14:07:31 +02:00
k0ga bda9c9ffa6 Make shift+wheel behaves as shift+Prev/Next
St uses a very good hack where mouse wheel genereates ^Y and ^E,
that are the same keys that less and vi uses for backward and
fordward scrolling. Scroll, as many terminal emulators, use
shift+Prev/Next for scrolling, but it is also using ^E and ^Y
for scroling, characters that are reserved in the POSIX shell
in emacs mode for end of line and yanking, making scroll unsable
in st.

This patch adds a new hack, making shift+wheel returning the
same sequences than shift+Prev/Next, meaning that scroll or
any other similar program will not be able to differentiate
between them.
2020-05-16 12:37:14 +02:00
Jakub Leszczak 045a0fab4f Fix selection: selscroll 2020-05-12 15:38:17 +02:00
Jakub Leszczak 9c30066e73 Fix selection: ignore ATTR_WRAP when rectangular selection in getsel 2020-05-12 15:38:02 +02:00
Jakub Leszczak 8304d4f059 Fix selection: selclear in tputc 2020-05-12 15:37:59 +02:00
Hiltjo Posthuma 914fb825df code-style: add fallthrough comment
Patch by Steve Ward, thanks.
2020-05-09 14:43:31 +02:00