refactor: compile on V 0.3.2

src/client/client.v

@@ -21,7 +21,7 @@ pub fn new(address string, api_key string) Client {
 
 // send_request_raw sends an HTTP request, returning the http.Response object.
 // It encodes the params so that they're safe to pass as HTTP query parameters.
-fn (c &Client) send_request_raw(method Method, url string, params map[string]string, body string) ?http.Response {
+fn (c &Client) send_request_raw(method Method, url string, params map[string]string, body string) !http.Response {
 	mut full_url := '$c.address$url'
 
 	if params.len > 0 {
@@ -38,31 +38,33 @@ fn (c &Client) send_request_raw(method Method, url string, params map[string]str
 		full_url = '$full_url?$params_str'
 	}
 
-	mut req := http.new_request(method, full_url, body)?
-	req.add_custom_header('X-Api-Key', c.api_key)?
+	// Looking at the source code, this function doesn't actually fail, so I'm
+	// not sure why it returns an optional
+	mut req := http.new_request(method, full_url, body) or { return error('') }
+	req.add_custom_header('X-Api-Key', c.api_key)!
 
-	res := req.do()?
+	res := req.do()!
 
 	return res
 }
 
 // send_request<T> just calls send_request_with_body<T> with an empty body.
-fn (c &Client) send_request<T>(method Method, url string, params map[string]string) ?Response<T> {
+fn (c &Client) send_request<T>(method Method, url string, params map[string]string) !Response<T> {
 	return c.send_request_with_body<T>(method, url, params, '')
 }
 
 // send_request_with_body<T> calls send_request_raw_response & parses its
 // output as a Response<T> object.
-fn (c &Client) send_request_with_body<T>(method Method, url string, params map[string]string, body string) ?Response<T> {
-	res_text := c.send_request_raw_response(method, url, params, body)?
-	data := json.decode(Response<T>, res_text)?
+fn (c &Client) send_request_with_body<T>(method Method, url string, params map[string]string, body string) !Response<T> {
+	res_text := c.send_request_raw_response(method, url, params, body)!
+	data := json.decode(Response<T>, res_text)!
 
 	return data
 }
 
 // send_request_raw_response returns the raw text response for an HTTP request.
-fn (c &Client) send_request_raw_response(method Method, url string, params map[string]string, body string) ?string {
-	res := c.send_request_raw(method, url, params, body)?
+fn (c &Client) send_request_raw_response(method Method, url string, params map[string]string, body string) !string {
+	res := c.send_request_raw(method, url, params, body)!
 
 	return res.body
 }

src/client/logs.v

@@ -6,40 +6,40 @@ import web.response { Response }
 import time
 
 // get_build_logs returns all build logs.
-pub fn (c &Client) get_build_logs(filter BuildLogFilter) ?Response<[]BuildLog> {
+pub fn (c &Client) get_build_logs(filter BuildLogFilter) !Response<[]BuildLog> {
 	params := models.params_from(filter)
-	data := c.send_request<[]BuildLog>(Method.get, '/api/v1/logs', params)?
+	data := c.send_request<[]BuildLog>(Method.get, '/api/v1/logs', params)!
 
 	return data
 }
 
 // get_build_logs_for_target returns all build logs for a given target.
-pub fn (c &Client) get_build_logs_for_target(target_id int) ?Response<[]BuildLog> {
+pub fn (c &Client) get_build_logs_for_target(target_id int) !Response<[]BuildLog> {
 	params := {
 		'repo': target_id.str()
 	}
 
-	data := c.send_request<[]BuildLog>(Method.get, '/api/v1/logs', params)?
+	data := c.send_request<[]BuildLog>(Method.get, '/api/v1/logs', params)!
 
 	return data
 }
 
 // get_build_log returns a specific build log.
-pub fn (c &Client) get_build_log(id int) ?Response<BuildLog> {
-	data := c.send_request<BuildLog>(Method.get, '/api/v1/logs/$id', {})?
+pub fn (c &Client) get_build_log(id int) !Response<BuildLog> {
+	data := c.send_request<BuildLog>(Method.get, '/api/v1/logs/$id', {})!
 
 	return data
 }
 
 // get_build_log_content returns the contents of the build log file.
-pub fn (c &Client) get_build_log_content(id int) ?string {
-	data := c.send_request_raw_response(Method.get, '/api/v1/logs/$id/content', {}, '')?
+pub fn (c &Client) get_build_log_content(id int) !string {
+	data := c.send_request_raw_response(Method.get, '/api/v1/logs/$id/content', {}, '')!
 
 	return data
 }
 
 // add_build_log adds a new build log to the server.
-pub fn (c &Client) add_build_log(target_id int, start_time time.Time, end_time time.Time, arch string, exit_code int, content string) ?Response<int> {
+pub fn (c &Client) add_build_log(target_id int, start_time time.Time, end_time time.Time, arch string, exit_code int, content string) !Response<int> {
 	params := {
 		'target':    target_id.str()
 		'startTime': start_time.unix_time().str()
@@ -48,7 +48,7 @@ pub fn (c &Client) add_build_log(target_id int, start_time time.Time, end_time t
 		'exitCode':  exit_code.str()
 	}
 
-	data := c.send_request_with_body<int>(Method.post, '/api/v1/logs', params, content)?
+	data := c.send_request_with_body<int>(Method.post, '/api/v1/logs', params, content)!
 
 	return data
 }

src/client/targets.v

@@ -5,21 +5,21 @@ import net.http { Method }
 import web.response { Response }
 
 // get_targets returns a list of targets, given a filter object.
-pub fn (c &Client) get_targets(filter TargetFilter) ?[]Target {
+pub fn (c &Client) get_targets(filter TargetFilter) ![]Target {
 	params := models.params_from(filter)
-	data := c.send_request<[]Target>(Method.get, '/api/v1/targets', params)?
+	data := c.send_request<[]Target>(Method.get, '/api/v1/targets', params)!
 
 	return data.data
 }
 
 // get_all_targets retrieves *all* targs from the API using the default
 // limit.
-pub fn (c &Client) get_all_targets() ?[]Target {
+pub fn (c &Client) get_all_targets() ![]Target {
 	mut targets := []Target{}
 	mut offset := u64(0)
 
 	for {
-		sub_targets := c.get_targets(offset: offset)?
+		sub_targets := c.get_targets(offset: offset)!
 
 		if sub_targets.len == 0 {
 			break
@@ -34,8 +34,8 @@ pub fn (c &Client) get_all_targets() ?[]Target {
 }
 
 // get_target returns the target for a specific id.
-pub fn (c &Client) get_target(id int) ?Target {
-	data := c.send_request<Target>(Method.get, '/api/v1/targets/$id', {})?
+pub fn (c &Client) get_target(id int) !Target {
+	data := c.send_request<Target>(Method.get, '/api/v1/targets/$id', {})!
 
 	return data.data
 }
@@ -49,24 +49,24 @@ pub struct NewTarget {
 }
 
 // add_target adds a new target to the server.
-pub fn (c &Client) add_target(t NewTarget) ?Response<int> {
+pub fn (c &Client) add_target(t NewTarget) !Response<int> {
 	params := models.params_from<NewTarget>(t)
-	data := c.send_request<int>(Method.post, '/api/v1/targets', params)?
+	data := c.send_request<int>(Method.post, '/api/v1/targets', params)!
 
 	return data
 }
 
 // remove_target removes the target with the given id from the server.
-pub fn (c &Client) remove_target(id int) ?Response<string> {
-	data := c.send_request<string>(Method.delete, '/api/v1/targets/$id', {})?
+pub fn (c &Client) remove_target(id int) !Response<string> {
+	data := c.send_request<string>(Method.delete, '/api/v1/targets/$id', {})!
 
 	return data
 }
 
 // patch_target sends a PATCH request to the given target with the params as
 // payload.
-pub fn (c &Client) patch_target(id int, params map[string]string) ?Response<string> {
-	data := c.send_request<string>(Method.patch, '/api/v1/targets/$id', params)?
+pub fn (c &Client) patch_target(id int, params map[string]string) !Response<string> {
+	data := c.send_request<string>(Method.patch, '/api/v1/targets/$id', params)!
 
 	return data
 }